Repository navigation
Conversation
add docks through insert at an index past the last tab, so a window takes one more than the leaf's highest rank and an already placed tab moves to the end of its bar. the draw-time sort breaks equal ranks by id, as insert's does, so the order no longer follows the state store's walk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #190
dock.addnow docks throughinsertat an index past the last tab, so the window takes one more than the leaf's highest rank (the others are renumbered 0..n-1 asinsertalready does) and is selected. The draw-time sortbefore()breaks equal ranks withahead(), by id, the same tie-breakinsertuses, so the order never follows the state store's walk.add's signature is unchanged.Decided beyond the issue: re-adding a window already placed in the leaf's bar now moves its tab to the end, since it goes through
insert'stabs.move. Before, its rank changed but the bar kept the tab where it was, which contradictedadd's "as its last tab".Test:
space__keeps_tabs_in_the_order_they_were_addedadds C, A, B to one leaf before its first draw and checks the tab order and front, then re-adds C after the draw.space__keyboard_crosses_docked_tabs_in_focus_orderassumed the old walk order (C's tab before B's though B was added first). It now steps left from C to B.Ran locally:
mach test . --filter blit.dock, plus the gallery and panel demo tests. Both pass and the gallery golden is unchanged.