Repository navigation
Conversation
every write of a fill through a path, set, set_path, TOML or a class also writes fill_to, so a fill alone is a flat face, and fill_to written with it or after it makes the gradient. a class or document writes fill_to after every fill whatever the order, a pop restores both, and a save writes fill_to after a changed fill whenever the two differ.
octalide
marked this pull request as ready for review
October 1, 2026 16:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #180
Plan
A paint's
fill_tofollows itsfill. Every write of a fill through the theme's field layer also writesfill_towith the same value, so a fill alone is a flat face, andfill_towritten with it (in any order) or after it makes the gradient.theme.follower(r)(fill -> fill_to of the same paint) andtheme.follows(r)name the relation once, at theReflevel.putstays the raw single-field write.theme.set,set_pathand TOMLapplywrite the follower.sheet.write(push, push_class) writes and saves the follower, so a pop restores both.push_classtakes a second pass,read_intoa third (PASS_FOLLOWS).savewritesfill_toafter a writtenfillwhenever the two differ, so a shaded face with a changed fill saves and loads back the same.Paint, thefill_toFIELDS row and the README (field table regenerated to match).Decisions the issue left open
Paintkeeps its layout and the box painter is unchanged.theme.set, so dragging a fill slider now flattens that paint'sfill_toas well, the same rule as every other path.dark). The gallery golden is the last frame of section 0, so it does not change and was not regenerated.Ran
mach test . --filter style|theme|editor|widget,mach test demo/gallery,mach build . -p release,mach fmt --checkon the root and demo/gallery.