[pull] master from gardener:master - #1893
Merged
Merged
Conversation
…offsets (#15388) * Extend MaintenanceTimeWindow validation pattern into negative timezone ranges * Run `make generate` * Restrict pattern to valid UTC timezones (PR review) * Update examples to include negative timezones (PR review) * Run `make generate`
…nnection (#15442) * Wait for vpn-shoot to be ready before proceeding * Wrap the Wait in a closure to prevent nil pointer panic for workerless shoots * Use managedresources.WaitUntilHealthyAndNotProgressing function for healthcheck * Fix unit test
… before rolling workers (#15430) * Wait for `kube-root-ca.crt` `ConfigMap`s to be updated before rolling workers during CA rotation During the `RotationPreparing` phase of CA rotation, `kube-controller-manager`'s `RootCACertificatePublisherController` must propagate the new CA bundle to the `kube-root-ca.crt` `ConfigMap` in every namespace before worker pools roll. Nodes that join before the `ConfigMap`s are updated only receive the old CA, which becomes invalid after rotation completes and breaks service account token validation. Note that `RootCACertificatePublisherController` runs with only a single worker (https://github.com/kubernetes/kubernetes/blob/0e5f0f9374ca822d0a5619088d4a00f335b8bafd/cmd/kube-controller-manager/app/certificates.go#L275-L287), so propagation can be slow in clusters with many namespaces or `ConfigMap` admission webhooks — hence the 5-minute retry window. Assisted-by: Claude <claude@anthropic.com> Signed-off-by: rfranzke <rafael.franzke@sap.com> * Address PR review feedback Signed-off-by: rfranzke <rafael.franzke@sap.com> --------- Signed-off-by: rfranzke <rafael.franzke@sap.com>
) * Add golangci-lint linter to enable default revive rules * Fix 'redefines-builtin-id' errors * Fix 'blank-imports' errors * Fix 'increment-decrement' errors * Fix 'superfluous-else' errors * Fix 'receiver-naming' errors * Run 'make generate' * Make comments inline * FIx more 'blank-imports' errors * Address 'ialidzhikov' comments * Make blank import comments inline and consistent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )