fix(pkgset): stop duplicating global PATH/GOPATH entries#14
Conversation
|
Warning Review limit reached
Next review available in: 57 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. 📝 WalkthroughWalkthroughThe change prevents duplicate global pkgset PATH/GOPATH entries, aligns installer behavior, adds validation coverage, improves binary download retries, sets CI timeouts, and ignores local planning artifacts. ChangesGlobal pkgset environment handling
Binary download retries
Repository maintenance
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Ubuntu bash smoke failed on a transient go.dev download, not the pkgset env checks. Retry binary downloads and ensure the archive dir exists. Also remove the committed plan doc, gitignore docs/plans and docs/brainstorms, and add a Cursor rule against committing plan files. Co-authored-by: Brian Thompson <brianrobt@users.noreply.github.com>
tf executes each line as its own command, so `cat <<EOF` blocked on stdin and held the suite jobs until the 6h Actions cancel. Write the fixture with a one-line printf, fix the myset GOPATH grep, and add job timeouts so a stuck test cannot burn the full budget again. Co-authored-by: Brian Thompson <brianrobt@users.noreply.github.com>
Remove .cursor/rules from the repo and gitignore .cursor/. AI prompts and rules stay on the machine unless explicitly requested in source control. Co-authored-by: Brian Thompson <brianrobt@users.noreply.github.com>
2 participants
Fixes #8
Summary
Base Go environment files already embed the
globalpkgset. Copying that file to*@globaland appending the same prefixes again duplicatedGOPATH/PATH.Changes
scripts/pkgset-create: forglobal, copy the base env and stop (no re-append). Non-global pkgsets unchanged.binscripts/gvm-installer:system@globalis a clean copy ofsystem; remove the@TODOappend block.tests/gvm_pkgset_global_comment_test.sh(single-line fixture write — no heredoc); smoke checks for@globalshape.scripts/install: retry flakygo.devbinary downloads; ensurearchive/exists.timeout-minuteson smoke (30) and suite (45)..cursor/,docs/plans/, anddocs/brainstorms/(AI rules/prompts and local plans stay off source control).CI failure notes
go.devdownload flake → retries added.gvm_listallfinished, the new pkgset test rancat <<EOF.tfruns each line as its own command, socatblocked on stdin until Actions cancelled the job. Fixed by writing the fixture with a one-lineprintf.Notes
@globalfiles are not migrated (by design).Summary by CodeRabbit
GOPATH/PATHentries when setting up or installing theglobalpackage set.globalenvironment generation to keep it as a clean base copy (while preserving correct precedence for non-global package sets).globalenvironments don’t include duplicated prefixes and that non-global package sets include expected overrides.