Skip to content

fix: replace math.Pow with exact integer constants #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DeVikingMark wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: replace math.Pow with exact integer constants #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gnark/koalabear/koalabear.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ func NewFConst(value string) Variable {
func NewF(value string) Variable {
return Variable{
Value: frontend.Variable(value),
UpperBound: new(big.Int).SetUint64(uint64(math.Pow(2, 32))),
UpperBound: new(big.Int).SetUint64(4294967296), // 2^32
}
}

Expand Down Expand Up @@ -387,7 +387,7 @@ func (p *Chip) reduceWithMaxBits(x frontend.Variable, maxNbBits uint64) frontend
// Check that the hint is correct.
p.api.AssertIsEqual(
p.api.Add(
p.api.Mul(highLimb, frontend.Variable(uint64(math.Pow(2, 27)))),
p.api.Mul(highLimb, frontend.Variable(134217728)), // 2^27
lowLimb,
),
remainder,
Expand Down Expand Up @@ -462,7 +462,7 @@ func SplitLimbsHint(_ *big.Int, inputs []*big.Int, results []*big.Int) error {
return fmt.Errorf("input is not in the field")
}

two_27 := big.NewInt(int64(math.Pow(2, 27)))
two_27 := big.NewInt(1).Lsh(big.NewInt(1), 27) // 2^27

// The least significant bits
results[0] = new(big.Int).Rem(input, two_27)
Expand Down