fix: bind EmbedMachine::verify to embed VK#102
Open
eason1981 wants to merge 1 commit into
Open
Conversation
Store the embed VK in an OnceLock during prove and use it directly in verify_ensemble, preventing a malicious prover from substituting an arbitrary recursion program VK and bypassing the embed circuit check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EmbedMachine::verifytook the VK directly from the proof (proof.vks()[0]) and passed it toverify_ensemblewithout checking it against the embed circuit VK. A malicious prover could prove an arbitrary recursion program, package its VK intoMetaProof, and have it accepted.Fix: store the embed VK in a
OnceLockduringprove, and use it inverify_ensembleinstead of the proof-supplied VK.