Skip to content
This repository was archived by the owner on Nov 21, 2021. It is now read-only.

Feature/add random range - #144

Open
ErezAmihud wants to merge 4 commits into
breuerfelix:masterfrom
ErezAmihud:feature/add-random-range
Open

Feature/add random range#144
ErezAmihud wants to merge 4 commits into
breuerfelix:masterfrom
ErezAmihud:feature/add-random-range

Conversation

@ErezAmihud

Copy link
Copy Markdown
Contributor

Fix #121

Idea:
Right now, every time we use the bot, we need to select a specific number for each action(posts to like, people to follow, precentage of private people to follow, etc). It can be an indication to instagram that we are using a bot and also forces the user to make multiple templates for things that can easily be randomized.

The way to solve it is randomize the number used each time - if the user desire it.

This mr contains the following:

  1. Change in auth.py and conf.py to print errors in stderr (before that, the errors did not print properly)
  2. Change to bot.py - handle the new range option, and also the old ones - for backward compatibility
  3. input_components.jsx - handle the web side of the change, it is visible on every setting page or template that requires int - note that this is the first time I wrote p/react and used css code so please don't go easy on me.

@breuerfelix

Copy link
Copy Markdown
Owner

thanks for this PR! for now, i still dont know if i want to go this approach for one reason:
we have multiple inputs in instapy that already use random range and if we go this approach we now have 4 inputs boxes for these inputs. we randomize the mininum and maximum values of the values, which instapy uses to randomize the actual values.

we should integrate the randomness into instapy because there is one big issue with the gui approach: the randomness only occurs one time at "script creation". sometimes, or almost everytime, you want instapy to keep generating random numbers for example if you want to calculate the sleep time from image like to image like. this wouldn't be possible with this approach :)

but i am open for new suggestions if this could be solveable in gui but right now i think the nicer way is to change instapy source code :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow randomisation of 'amount' parameter in actions which provide it

2 participants