Skip to content

fix(settings): scrollable panel + close on Escape/backdrop #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brettchien wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(settings): scrollable panel + close on Escape/backdrop #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion sidepanel.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,7 +686,11 @@ body {
background: rgba(10, 15, 26, 0.85);
backdrop-filter: blur(8px);
-webkit-backdrop-filter: blur(8px);
justify-content: center;
/* flex-start + margin:auto on the card (not justify-content:center) so overflow
scrolls correctly — centering via justify-content clips the overflowed start
of the content out of scroll reach when it doesn't fit. */
justify-content: flex-start;
overflow-y: auto;
padding: 24px;
}

Expand All @@ -699,6 +703,8 @@ body {
display: flex;
flex-direction: column;
gap: 20px;
margin: auto 0;
flex-shrink: 0;
}

.settings-card h2 {
Expand Down
8 changes: 8 additions & 0 deletions sidepanel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,6 +860,14 @@ settingsBtn.addEventListener("click", () => {

cancelSettingsBtn.addEventListener("click", () => switchView("chat"));

// Close on Escape or a click on the backdrop itself (not the card) — standard modal UX.
document.addEventListener("keydown", (e) => {
if (e.key === "Escape" && settingsView.classList.contains("active")) switchView("chat");
});
settingsView.addEventListener("click", (e) => {
if (e.target === settingsView) switchView("chat");
});

// Clear the on-screen scrollback + this window's persisted mirror (storage.session). The agents'
// resumable ACP sessions are deliberately KEPT — this wipes the local transcript without making the
// agents forget, so `session/resume` still restores their side of the conversation on reconnect,
Expand Down