Replace threading.Lock with asyncio.Lock in forecaster - #26
Merged
GrowlyX merged 1 commit intoSep 4, 2026
Merged
Conversation
Torch is re-entrant but produces nondeterministic garbage under memory pressure when called concurrently from multiple threads. The previous threading.Lock serialised inference correctly, but at the cost of blocking the entire thread -- health checks, queue handling, and other requests all piled up behind a single forecast. asyncio.Lock is still serialising at the model level, so correctness is preserved. The rest of the server (healthz, readyz, /v1/model, the async lifespan) is never behind the lock, and multiple prediction requests queue cooperatively without blocking the event loop. Test suite: 31 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Torch is re-entrant but produces nondeterministic garbage under memory pressure when called concurrently from multiple threads. The previous
threading.Lockserialised inference correctly, but at the cost of blocking the entire thread — health checks, queue handling, and other requests all piled up behind a single forecast.Solution
TimesFMModel.forecast()is nowasync def forecast()usingasyncio.Lockinstead ofthreading.Lockserver.py: endpoint is nowasync defand usesawait model.forecast()What was not done
Verification
All 31 Python tests pass (
uv run --extra dev pytest -q).