Laravel 8 support, Jira v3 API compatibility, Fix paginate request with query params, Fix naming collision with jwt-auth. by henritoivar · Pull Request #16 · breart/atlassian-connect-core

henritoivar · 2020-11-04T21:30:30Z

Updated dependencies to support Laravel 8.
Updated Jira Paginator to use v3 API conventions.
Fixed query parameters being overwritten by default pagination parameters, when providing query parameters to $client->paginate.
Made guard name and middleware name more specific to avoid naming collision with tymon/jwt-auth. Ideally thiese two could be defined in the config?

breart · 2020-11-08T19:30:01Z

    }
-}
+
+    protected function serializeDate(DateTimeInterface $date)


Why is it needed?

The default date serialization format was changed in Laravel 7. See here: https://laravel.com/docs/7.x/upgrade#date-serialization

breart · 2020-11-08T19:31:39Z

    Route::post('disabled', 'TenantController@disabled')->name('disabled');

-    Route::group(['middleware' => 'jwt'], function () {
+    Route::group(['middleware' => 'auth.atlassian'], function () {


Is it a collision for you? We could rename it like this, but I want to understand whether this is a real issue.

Furthermore, we need to update README, so users will define this middleware instead.

I managed a simpler solution for this by directly referencing the class. See commit brezzhnev/atlassian-connect-core@942c6cf

breart · 2020-11-08T19:33:28Z

    protected function registerJWTGuard()
    {
-        Auth::extend('jwt', function (Application $app, $name, array $config)
+        Auth::extend('jwt.atlassian', function (Application $app, $name, array $config)


Do you experience a collision in a real project?

Hey, yes i have a project where i use tymondesigns/jwt-auth which also names it's guard "jwt". I have updated the pull-request to make this configurable: brezzhnev/atlassian-connect-core@942c6cf

breart · 2020-11-08T19:35:23Z

@henritoivar thanks for the contribution. If we add support for v3 API, v2 won't be longer supported. Would that be an issue?

I'll also add support for L7 in this PR since there is not a lot of changes between those.

…n header. This is causing the requests to redirect instead of returning json in case the validation does not pass.

… Atlassian Account ID from the sub property of the JWT claim instead.

…ame tag. Directly reference middleware so user doesn't have to use exact alias in vendor file.

henritoivar · 2020-11-09T12:19:30Z

I have added a few more adjustments:

dispatcher fire method has been removed in laravel 5.8, use dispatch instead
jira doesn't include user_key and user_id anymore in the request. See here: https://developer.atlassian.com/cloud/jira/platform/context-parameters/
Also atlassian callbacks do not include the Accept header with value application/json. This will make Laravel redirect in case validation does not pass. I have overriden this behaviour so validation messages are always returned as json.

henritoivar · 2020-11-09T12:20:07Z

@henritoivar thanks for the contribution. If we add support for v3 API, v2 won't be longer supported. Would that be an issue?

I'll also add support for L7 in this PR since there is not a lot of changes between those.

I use only v3, so it's not a problem for me.

…same query then the second request returns data from the previous request.

leganz · 2021-01-25T15:54:16Z

Are there any plans to integrate that PR into master? It would be pretty nice, cause i have laravel 8 project which would benefit from that :-)

mystiquewolf · 2021-03-18T20:29:15Z

@henritoivar Is it possible/reasonable for me to manually merge this pull request locally so i can use this in Laravel 8, is it stable enough in your opinion?

henritoivar · 2021-03-19T07:59:01Z

@mystiquewolf I'm using this in production myself. So far no issues.

Until this gets merged you could use my fork (or fork my fork.. hehe) directly like this in your composer.json:

"require": {
  "brezzhnev/atlassian-connect-core": "dev-master",
  ...
},
"repositories": {
   {
       "type": "vcs",
       "url": "https://github.com/henritoivar/atlassian-connect-core"
   }
}

Also validate requests that are coming from Atlassian. We need to strip our base url to properly calculate QSH. See here: https://developer.atlassian.com/cloud/bitbucket/query-string-hash/ Actually validate JWT from requests sent by Atlassian. Also validate QSH for these requests.

breart · 2021-08-04T17:25:48Z

Sorry guys for abandoning this repo, I can't manage to find time to maintain and improve this package. I'm happy to invite someone as a collaborator on this project, making sure every change gets tested and follows the project coding style.

Please send an email to brezzhnev@gmail.com if you're interested.

…n-required-atlassian-connect-installation-lifecycle-security-improvements/49046

henritoivar added 6 commits November 2, 2020 23:38

Updated guzzle from 6 to 7.

cc23e01

Update dependencies for Laravel 8. Fix related tests.

4bdb363

Be able to work side by side with tymon/jwt-auth

46bfe14

Update jira paginator to match v3 of rest api.

a71f38d

Fix bug where query params are overwritten when using pagination.

0055b57

Fix tests regarding changes to jira paginator.

d1799cc

breart reviewed Nov 8, 2020

View reviewed changes

henritoivar added 4 commits November 9, 2020 12:28

Atlassian api callbacks are not including the Accept: application/jso…

625552f

…n header. This is causing the requests to redirect instead of returning json in case the validation does not pass.

user_key and user_id have been removed. To identify the user, use the…

c6cf318

… Atlassian Account ID from the sub property of the JWT claim instead.

Fire has been deprecated since 5.4 and removed in 5.8.

290b664

Be able to override guard tag/alias in case another vendor uses the s…

942c6cf

…ame tag. Directly reference middleware so user doesn't have to use exact alias in vendor file.

Always recreate paginator. If running two pagination requests in the …

3628698

…same query then the second request returns data from the previous request.

Quickfix regarding: https://community.developer.atlassian.com/t/actio…

3cc4515

…n-required-atlassian-connect-installation-lifecycle-security-improvements/49046

Navigation Menu

Laravel 8 support, Jira v3 API compatibility, Fix paginate request with query params, Fix naming collision with jwt-auth. - #16

Laravel 8 support, Jira v3 API compatibility, Fix paginate request with query params, Fix naming collision with jwt-auth.#16
henritoivar wants to merge 13 commits into
breart:masterfrom
henritoivar:master

henritoivar commented Nov 4, 2020

Uh oh!

breart Nov 8, 2020

Uh oh!

henritoivar Nov 9, 2020

Uh oh!

breart Nov 8, 2020

Uh oh!

henritoivar Nov 9, 2020 •

edited

Loading

Uh oh!

breart Nov 8, 2020

Uh oh!

henritoivar Nov 9, 2020

Uh oh!

breart commented Nov 8, 2020

Uh oh!

henritoivar commented Nov 9, 2020

Uh oh!

henritoivar commented Nov 9, 2020

Uh oh!

leganz commented Jan 25, 2021

Uh oh!

mystiquewolf commented Mar 18, 2021

Uh oh!

henritoivar commented Mar 19, 2021

Uh oh!

breart commented Aug 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

henritoivar commented Nov 4, 2020

Uh oh!

breart Nov 8, 2020

Choose a reason for hiding this comment

Uh oh!

henritoivar Nov 9, 2020

Choose a reason for hiding this comment

Uh oh!

breart Nov 8, 2020

Choose a reason for hiding this comment

Uh oh!

henritoivar Nov 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

breart Nov 8, 2020

Choose a reason for hiding this comment

Uh oh!

henritoivar Nov 9, 2020

Choose a reason for hiding this comment

Uh oh!

breart commented Nov 8, 2020

Uh oh!

henritoivar commented Nov 9, 2020

Uh oh!

henritoivar commented Nov 9, 2020

Uh oh!

leganz commented Jan 25, 2021

Uh oh!

mystiquewolf commented Mar 18, 2021

Uh oh!

henritoivar commented Mar 19, 2021

Uh oh!

breart commented Aug 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

henritoivar Nov 9, 2020 •

edited

Loading