Skip to content

If there's no reference or reference has no url, do not include doc-url #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
driesva wants to merge 1 commit into
base: main
Choose a base branch
from
Open

If there's no reference or reference has no url, do not include doc-url #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/jet-brains-integration/src/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface Options extends BaseOptions {
prefix?: string;
/** Adds a suffix to tag references */
suffix?: string;
/** Automatically adds reference to yor package.json */
/** Automatically adds reference to your package.json */
packageJson?: boolean;
/** Used to create a link within the component info bubble */
referenceTemplate?: (name: string, tag?: string) => Reference;
Expand Down
2 changes: 1 addition & 1 deletion packages/jet-brains-integration/src/web-types-generator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export function getTagList(
component.tagName || toKebabCase(component.name)
}${options.suffix}`,
description: getComponentDetailsTemplate(component, options),
["doc-url"]: reference?.url || "",
...(reference?.url && { "doc-url": reference.url }),
attributes: getComponentAttributes(component, options.typesSrc),
slots: component.slots?.map((slot) => {
return {
Expand Down