Repository navigation
chore(data): add NCM 85181020, in force since 01/10/2026 - #621
Merged
Merged
Conversation
…ed datasets `npm run build:data` printed only the error of a failing generator, so the two scheduled refreshes that died on "fetch failed" never said which source was down. It now names the generators that failed, and takes dataset names (`npm run build:data -- ncm`) to rebuild only those. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CQThRoG9YWRFiufSvq2hXS
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CQThRoG9YWRFiufSvq2hXS
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Contributor
Tree-shaking report✅ No size regression. 1 grew out of 200 exports.
What changed (1)
All exports (200)
How this is measuredEvery export is imported alone into an esbuild consumer bundle (minified, tree-shaken) built from the head and from the base of this pull request; the sizes are the resulting bundles, gzip is their gzipped size. 🔴 marks a regression: a pre-existing export that grew more than 20% and more than 256 B, or the bundle importing every pre-existing export growing more than 5%. 🟡 is growth under the threshold, 🟢 a decrease, ⚪ no change, 🆕 an export that does not exist on the base (never a regression), 🗑️ an export that was removed. An intentional increase is accepted with the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #621 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 263 263
Lines 2656 2656
Branches 754 754
=========================================
Hits 2656 2656
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…isories OSV-Scanner fails on GHSA-6j4f-fj2g-mc7p, GHSA-q2hr-2g5m-vwhr and GHSA-qhr7-859c-m2p7 (brace-expansion 2.1.4 and 5.0.9) and on GHSA-hrr3-gc8f-f4qj (fast-uri 3.1.7), all published after the last green run on main. Both are development-only. The brace-expansion@2 override now starts at the fixed 2.1.7, and the lockfile resolves 5.0.12 and 3.1.8. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CQThRoG9YWRFiufSvq2hXS
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refreshes the NCM table before the 2.5.0 release, so
isValidNcm("8518.10.20")returnstrue. Siscomex puts that code in force on 01/10/2026, between85181010and85181090.chore(data): update the embedded datasets: the NCM table regenerated by the "Update datasets" workflow (run, dispatched on this branch withdatasets: ncm). After decoding the packed table, the only change is the new code: 10,515 → 10,516 codes, none removed. The header comment rewrap is the generator's own wording, whichmainhad drifted from.fix(scripts):npm run build:datanow names the generators that failed, and takes dataset names (npm run build:data -- ncm) to rebuild only those. The two scheduled refreshes so far (21/09, 28/09) died on a barefetch failedthat never said which source was down.ci(datasets): a manual run of the workflow takes adatasetsinput. It is passed through an env var and split withread -ra, so it is never interpolated into the script.chore(deps-dev): OSV-Scanner started failing on new advisories against dev-only dependencies, somainwould go red on its next run too: GHSA-6j4f-fj2g-mc7p, GHSA-q2hr-2g5m-vwhr and GHSA-qhr7-859c-m2p7 (brace-expansion2.1.4 / 5.0.9), and GHSA-hrr3-gc8f-f4qj (fast-uri3.1.7). Thebrace-expansion@2override now starts at the fixed 2.1.7, and the lockfile resolves 5.0.12 and 3.1.8. Inpackage-lock.json, only those entries' version, resolved and integrity change.This replaces #620, which the workflow opened with the same data commit. A PR opened with
GITHUB_TOKENgets no CI.Checklist
22030000,01012100), and the doc example84713012is still in the table.npm run checkpasses locally.vp test --runalso passes: 274 files, 8520 tests.check:lockfileand jscpd pass, andactionlintandzizmor --offlineare clean on the workflow.Additional context
scripts/data-summary.tsstill prints the NCM diff as packed base 36 deltas (a,/1y,) instead of codes, as chore(data): update the embedded datasets #620's body shows. It predates the packed format; worth a follow-up.🤖 Generated with Claude Code
https://claude.ai/code/session_01CQThRoG9YWRFiufSvq2hXS