Repository navigation
ci(tests): run Chrome and Edge one test file at a time from the first attempt - #612
Merged
Merged
Conversation
… attempt With test files in parallel, Chrome and Edge lost a test iframe on most runs and sat silent until the 300s timeout before the one-file-at-a-time retry, which then finished in 50 to 70s. They now start one file at a time; Firefox keeps running in parallel. The first attempt times out after 240s and the retries after 300s, still well above a normal run. The local test:chrome-browser and test:edge-browser scripts match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RLkm9YrtAifc6XCLFVEsdH
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Contributor
Tree-shaking report✅ No bundle size impact. All 185 exports are the same size as on the base branch (full import 1985.9 KB, gzip 378.2 KB). All exports (185)
How this is measuredEvery export is imported alone into an esbuild consumer bundle (minified, tree-shaken) built from the head and from the base of this pull request; the sizes are the resulting bundles, gzip is their gzipped size. 🔴 marks a regression: a pre-existing export that grew more than 20% and more than 256 B, or the bundle importing every pre-existing export growing more than 5%. 🟡 is growth under the threshold, 🟢 a decrease, ⚪ no change, 🆕 an export that does not exist on the base (never a regression), 🗑️ an export that was removed. An intentional increase is accepted with the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #612 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 218 218
Lines 2252 2252
Branches 673 673
=========================================
Hits 2252 2252
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes the Chrome and Edge browser jobs about 4 to 5 minutes faster by starting them one test file at a time.
Timings from the logs of one run (the
#611head, commit313bf14):Chrome and Edge are not slow browsers. Their clean runs are faster than Firefox's. Almost all of their time went to the first attempt: with test files in parallel it lost a test iframe (the known webdriverio issue the retry step exists for) and waited out the 300s timeout before the retry ran one file at a time. Running in parallel also gave no speedup: file results arrive one at a time either way (about 0.2s per file on Chrome in both modes).
The PR changes three things:
--no-file-parallelism. Firefox keeps running in parallel.test:chrome-browserandtest:edge-browserpass the same flag, so a local run doesn't hit the hang either.The lost-iframe retry stays, so a rare loss in serial mode is still retried.
Checklist
docs/utilities.mdanddocs/pt-br/utilities.md: not applicable.npm run checkpasses locally (format, lint, types).npm run build:llms:docs/untouched.Additional context
The step script was checked with
bash -nand run against a stubvp:--no-file-parallelism, Firefox without it.This PR's own CI run is the real measurement.
🤖 Generated with Claude Code
https://claude.ai/code/session_01RLkm9YrtAifc6XCLFVEsdH
Generated by Claude Code