Repository navigation
fix(states): read the state code ignoring case in every state-taking util - #604
Merged
hyanmandian merged 17 commits intoSep 29, 2026
Merged
Conversation
…util getMunicipalities, getCities, generateCpf, generateVoterId and isValidRegistroProfissional matched the state code exactly, so "sp" returned no municipality, drew a random região fiscal, fell back to "ZZ" or failed the UF check. They now read it through readStateCode (trim and upper case, then an exact state code), like getStateNameByCode, getTimezoneByState, getAreaCodesByState and getMunicipality already did; readHolidayStateCode builds on it. What an unknown code means is unchanged in each util. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RLkm9YrtAifc6XCLFVEsdH
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Contributor
Tree-shaking report✅ No size regression. 18 grew, 1 shrank out of 194 exports.
What changed (19)
All exports (194)
How this is measuredEvery export is imported alone into an esbuild consumer bundle (minified, tree-shaken) built from the head and from the base of this pull request; the sizes are the resulting bundles, gzip is their gzipped size. 🔴 marks a regression: a pre-existing export that grew more than 20% and more than 256 B, or the bundle importing every pre-existing export growing more than 5%. 🟡 is growth under the threshold, 🟢 a decrease, ⚪ no change, 🆕 an export that does not exist on the base (never a regression), 🗑️ an export that was removed. An intentional increase is accepted with the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## claude/holiday-state-code #604 +/- ##
===========================================================
Coverage 100.00% 100.00%
===========================================================
Files 235 237 +2
Lines 2418 2414 -4
Branches 720 712 -8
===========================================================
- Hits 2418 2414 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
generateCpf, generateVoterId, getMunicipalities and getCities are each keyed by the state codes already, so they normalize the code (normalizeStateCode, trim and upper case) and look it up in their own table (hasOwnKey) instead of bundling the list of the 27 codes: generateCpf and generateVoterId grow by 86 B instead of 240 B and 219 B. readStateCode, for the utils that need the list anyway, builds on normalizeStateCode. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RLkm9YrtAifc6XCLFVEsdH
7 tasks done
… iframe Ported from #595 (3d1ca00), which targets main: Edge failed twice on this branch with "Cannot connect to the iframe" in assemble-boleto-bancario.test.ts, a file this stack does not touch. The change is identical to #595's, so it merges cleanly whichever of the two lands first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RLkm9YrtAifc6XCLFVEsdH
Member
Author
|
Test on Browsers (edge) failed on both 764c484 and c947d54 with #595's workflow change is ported here as f462c71 (the Generated by Claude Code |
…ywhere getStateCapital, getMunicipality, getTimezoneByState, getStateNameByCode and getAreaCodesByState each trimmed and upper cased the state code by hand. They now use normalizeStateCode, and the ones keyed by the state codes look it up with hasOwnKey in their own table (getStateCapital no longer bundles the list of the 27 codes: -129 B). No behavior changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RLkm9YrtAifc6XCLFVEsdH
7 tasks done
Member
Author
|
On 5a279f8,
That is the Chromium/webdriverio flake. This PR's code isn't involved: all 7410 tests that ran passed, and Edge, Firefox and Safari are green on the same commit. I re-ran the failed job once. If Chrome still fails after that, I'll look at making the retry step more robust for the whole stack. Generated by Claude Code |
hyanmandian
pushed a commit
that referenced
this pull request
Sep 28, 2026
One retry was not enough: Chrome lost an iframe on both attempts in #600 and #604. The retries now run with --no-file-parallelism, since the iframes are lost when many files load at once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RLkm9YrtAifc6XCLFVEsdH
6 tasks done
isValidIe upper cased the state code but kept its whitespace, so " sp " was refused while every other util of #604 read it as SP. It now reads the code through normalizeStateCode. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RLkm9YrtAifc6XCLFVEsdH
hyanmandian
added this pull request to stack #614
September 29, 2026 04:08
fengmk2
pushed a commit
to vite-plus-ecosystem-ci/brazilian-utils-javascript
that referenced
this pull request
Oct 6, 2026
One retry was not enough: Chrome lost an iframe on both attempts in brazilian-utils#600 and brazilian-utils#604. The retries now run with --no-file-parallelism, since the iframes are lost when many files load at once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RLkm9YrtAifc6XCLFVEsdH
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stacks on #603. Six utils did not read the state code the way the rest of the library does, so a lower-case or padded code behaved like an unknown one:
getMunicipalities"sp"[]getCities"sp"[]generateCpf"sp"8, the SP região fiscalgenerateVoterId"sp""ZZ"(UF28)01)isValidRegistroProfissional(stateCode)"sp"falsefor"123456-SP"trueisValidIe(stateCode)" sp "false(it upper-cased the code but did not trim it)"SP"Two new internal helpers do the reading:
normalizeStateCodetrims and upper-cases the code.isValidIeuses it.readStateCodenormalizes the code and then checks it against the 27 state codes, returningnullwhen it isn't one.isValidRegistroProfissionaland fix(holidays): read stateCode like the other state utils, and follow the official texts on the open holiday questions #603's holiday utils use it.The utils that are already keyed by the state codes (
generateCpf,generateVoterId,getMunicipalities,getCities,isValidIe) look the normalized code up in their own table throughhasOwnKey, so they don't bundle the code list.getStateNameByCode,getTimezoneByState,getAreaCodesByStateandgetMunicipalityalready followed this rule.What an unknown code means is unchanged in every util:
getMunicipalitiesstill returns[];getCitiesstill reads a falsystateas the full list;The only change is that a real state code written in another case or with padding is now accepted. No return type changes, so
check:apipasses.The JSDoc and both docs drop the "case-sensitive" notes and say what 2.4.0 did. For
isValidIe, they now say that surrounding whitespace is ignored.Checklist
docs/utilities.mdanddocs/pt-br/utilities.md.npm run checkpasses locally. These also pass: coverage (100%), Stryker on the changed files (100%,is-valid-ie.tsincluded), Deno, Bun,check:unused,check:duplicationandcheck:api(no breaking change against 2.4.0).npm run build:llms.Additional context
The tree-shaking report shows no size regression. The generators and
getMunicipalities/getCitiesgrow by about 86 to 94 B, andisValidRegistroProfissionalby about 100 B.🤖 Generated with Claude Code
https://claude.ai/code/session_01RLkm9YrtAifc6XCLFVEsdH