WIP: Multiple barcode support - #337
Open
TheLastProject wants to merge 17 commits into
Open
Conversation
…roject/loyalty-card-locker into feature/multiple-barcodes
Contributor
Author
|
|
Contributor
Author
|
I moved the tab bar into the header, which at least makes the situation not worse than it used to be. |
Contributor
Author
|
This sadly seems to conflict with the feature introduced in #348 and I'm not quite sure how to fix that :( |
This was referenced Oct 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After seeing #279, I felt the tabs were a good way to support multiple barcodes.
Fixes #264 and I feel it also fixes #279 (because multiple barcodes per store make this possible, just note what the code is for). I am also going to assume this fixes #286 as the user's primary concern seems to be an easier way to add another card from a store they already have.
This code groups together every loyalty card with the same store name and, if multiple loyalty cards with the same store name exist, adds a scrollable tabview to switch between them. The text on each tab is based on the note. If there is no note for that specific loyalty card, it falls back to numbering them. It also switches to using a floating action button. Clicking the "+" button when viewing a loyalty card will start the edit activity with the store name pre-filled, to make adding additional cards to the same store easy.
Some screenshots:
