Add types - #1
Open
azdavis wants to merge 1 commit into
Open
Conversation
Owner
|
This is now conflicting because of bug fixes which were applied. It would also be good to squash it down and have fewer individual commits. But the general clean up is good. |
azdavis
force-pushed
the
main
branch
4 times, most recently
from
June 16, 2026 00:09
5f51848 to
d45bfdb
Compare
Author
|
Ok, I rebased and squashed. All tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, cool project. I found it a bit hard to follow the types in the reference code, so I tried adding type annotations from what I could discern was the intent.
There were a few places where I wasn't sure where the boundary was for assuming optional things to be non-optional; I made that explicit with
_unwrap.I also
_ConflictenumI put this patch into the public domain so that the project may remain entirely in the public domain.
Testing
All tests passed.