Skip to content

Add types - #1

Open
azdavis wants to merge 1 commit into
bramcohen:mainfrom
azdavis:main
Open

Add types#1
azdavis wants to merge 1 commit into
bramcohen:mainfrom
azdavis:main

Conversation

@azdavis

@azdavis azdavis commented Mar 22, 2026

Copy link
Copy Markdown

Hi, cool project. I found it a bit hard to follow the types in the reference code, so I tried adding type annotations from what I could discern was the intent.

There were a few places where I wasn't sure where the boundary was for assuming optional things to be non-optional; I made that explicit with _unwrap.

I also

  • replaced unused vars with _
  • put most imports at the top
  • used tuples instead of lists in one place( I think lists were used so it was easier to mutate, so I made a helper function to return a new tuple instead)
  • use a Conflict enum
  • use dataclasses with labeled fields instead of tuples

I put this patch into the public domain so that the project may remain entirely in the public domain.

Testing

All tests passed.

@bramcohen

Copy link
Copy Markdown
Owner

This is now conflicting because of bug fixes which were applied. It would also be good to squash it down and have fewer individual commits. But the general clean up is good.

@azdavis
azdavis force-pushed the main branch 4 times, most recently from 5f51848 to d45bfdb Compare June 16, 2026 00:09
@azdavis

azdavis commented Jun 16, 2026

Copy link
Copy Markdown
Author

Ok, I rebased and squashed. All tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants