fix(experiments): pass base_experiment_id to summarize#512
Open
Barrett Pyke (barrettpyke) wants to merge 1 commit into
Open
fix(experiments): pass base_experiment_id to summarize#512Barrett Pyke (barrettpyke) wants to merge 1 commit into
Barrett Pyke (barrettpyke) wants to merge 1 commit into
Conversation
Abhijeet Prasad (AbhiPrasad)
left a comment
Abhijeet Prasad (AbhiPrasad)
left a comment
Member
There was a problem hiding this comment.
base_experiment_name also has the same bug here. We need to fix that too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Eval stores base_experiment_id correctly on the experiment but the final summary does not pass it as the explicit comparison ID. As a result, summary comparison can fall back to project/default baseline resolution and show wrong diffs.
Fix
Pass
evaluator.base_experiment_idintoexperiment.summarize(comparison_experiment_id=...), so score and metric diffs are computed against the explicit experiment baseline.Also resolve the explicit comparison experiment name so the returned summary displays the correct “compared to” name. Previously,
comparison_experiment_idwasNone, sosummarize()calledPOST /api/base_experiment/get_id; that resolver can apply UI/default-baseline behavior, including letting a project default baseline override the experiment’s explicitbase_exp_id.