Skip to content

Add **kwargs type hint in Atlas.get_plane#456

Merged
IgorTatarnikov merged 2 commits into
brainglobe:mainfrom
AlgoFoe:format-api-ref
Jun 24, 2026
Merged

Add **kwargs type hint in Atlas.get_plane#456
IgorTatarnikov merged 2 commits into
brainglobe:mainfrom
AlgoFoe:format-api-ref

Conversation

@AlgoFoe

@AlgoFoe AlgoFoe commented Jun 22, 2026

Copy link
Copy Markdown
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

  • Update type hint for **kwargs in Atlas.get_plane.

What does this PR do?

  • Adds **kwargs: Any type hint.

References

How has this PR been tested?

  • Verified locally that the type hint is correct and no existing functionality is affected.

Is this a breaking change?

  • No.

Does this PR require an update to the documentation?

  • No.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.41%. Comparing base (a926b85) to head (2b9ac73).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
+ Coverage   88.22%   89.41%   +1.19%     
==========================================
  Files          27       27              
  Lines        1282     1285       +3     
==========================================
+ Hits         1131     1149      +18     
+ Misses        151      136      -15     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IgorTatarnikov IgorTatarnikov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @AlgoFoe

@IgorTatarnikov IgorTatarnikov merged commit 55c8b6c into brainglobe:main Jun 24, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants