updated lib version, fixed build command, WIP handbook#8
updated lib version, fixed build command, WIP handbook#8NekoMimiOfficial wants to merge 4 commits into
Conversation
| override val settingItems: List<Setting> = listOf(switchInput) | ||
| ``` | ||
| **`SettingSlide()`**: A slider to choose a numerical value | ||
| This entry has: |
There was a problem hiding this comment.
Why this inconsistency? setting switch doenst list all the parameters
this shouldnt either, and its better to refer the javadoc
There was a problem hiding this comment.
it does? title, key, summary, defaultValue
- @param title The title of the setting.
- @param key The key of the setting.
- @param summary The summary of the setting.
- @param defaultValue The default value of the setting.
There was a problem hiding this comment.
I am talking bout this inconsistency
SettingSwitch shows all of them in a single line, while this shows them one by one indiviually
| override fun setSettings(settings: Settings) { | ||
| setting= settings | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Honestly, I suggest making this section just let the user read the java doc if they want to understand stuff in details,
its best to just show SettingSwitch in this section, since its what most of the extensions would use
There was a problem hiding this comment.
Instead of writing this, I suggest you incoporate stuff from the readme to Handbook and updtae the readme to just link the handbook
|
love to accidentally click approve instead of request changes 😭 |
|
now? :'3 |
| ## What is an extension ? | ||
| We can't dive straight into creating the extension without first knowing how one works, apart from the main code that sets up a kotlin/Android project you start with your main class, that class extends multiple interfaces to add the features you need (lets say you want to create an extension that only does lyrics, then you'd need the LyricsClient interface) | ||
| We will divide our code into segements to keep things easier to read and help others be able to contrib to your project, we will also stick to the kotlin indent style and syntax rules (because people will shit on you otherwise) | ||
| Your main class file should only contain declarations and overrides, you are advised to not implement any of the logic in this file but rather to call functions from other files |
There was a problem hiding this comment.
I recommend to replace this line with
Its better to have your main class file only contain declarations and overrides, you are advised to not implement any of the logic in this file but rather to call functions from other files. This will keep your main class clean and readable.
2 participants
No description provided.