Repository navigation
fix: keep cuts and audio edits across trim changes, decode caption escapes - #1
Merged
Merged
Conversation
…capes - Trim and cut changes stored cuts, master fades and the audio mix re-normalized against the current trim. The trim handle dispatches on every pointer move, so dragging past a cut and back deleted it and shortened fades for good. Settings now keep the values as entered (bounded to the source duration) and every consumer applies the current trim when it reads them. - WebVTT character references such as & and < showed literally in burned captions. The parser now decodes named and numeric references after removing styling tags.
Deploying videoadjust with
|
| Latest commit: |
6fef8d6
|
| Status: | ⚡️ Build in progress... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setTrimruns on every pointer move and stored cuts, master fades and the audio mix normalized against the current trim. Dragging the end handle past a cut and back removed the cut; fades and the added-audio offset were shortened for good. Stored values now stay as entered (bounded to the source duration). Export, preview, cut rows, filmstrip marks, change counts and copy/passthrough eligibility apply the current trim when they read them. Cuts outside the trim stay stored and return when the trim widens.&,<and similar showed literally in burned captions. The parser now decodes named and numeric character references after removing styling tags.Verification
pnpm test: 497/497 pass. Regression tests added for both bugs and confirmed failing first (cuts: []after a drag past and back;Received: "Tom & Jerry <3").