ci: pin rust-toolchain action to allowlisted SHA in release workflow - #6
Closed
Wollac wants to merge 1 commit into
Closed
ci: pin rust-toolchain action to allowlisted SHA in release workflow#6Wollac wants to merge 1 commit into
Wollac wants to merge 1 commit into
Conversation
The boundless-xyz org enforces an action allowlist; dtolnay/rust-toolchain@stable is not on it. Match the SHA already used in ci.yml. Caused 'startup_failure' on the first manual workflow_dispatch run.
Contributor
Author
|
Superseded by #4 - same content, repurposed there to preserve approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first manual `workflow_dispatch` run of `release.yml` failed with `startup_failure` because the org-level action allowlist rejected `dtolnay/rust-toolchain@stable`. Pin it to `@6d653acede28d24f02e3cd41383119e8b1b35921` (the same SHA `ci.yml` uses) and pass `toolchain: stable` via `with:`.
Open question
`rust-lang/crates-io-auth-action@v1` is the next step in the workflow. The dispatch never reached it (failed at startup), so it's unclear whether it's also on the allowlist. If a follow-up dispatch fails on it next, an admin will need to add it to the allowlist (it's the official rust-lang action for crates.io Trusted Publishing OIDC token exchange).
Test plan