BM-3086: fix(examples): repair nightly examples — missing bytes-compat remapping - #2062
Merged
Conversation
…equestor PR #2044 added a bytes-compat import to contracts/src/types/Predicate.sol and the corresponding remapping to the root foundry.toml, but the smart-contract-requestor example has its own remappings.txt that was not updated, breaking its forge build in the nightly examples workflow. Also add --fail to the blake3 groth16 artifact download so a missing artifact fails the download step instead of passing an HTML error page to tar.
jonastheis
requested review from
a team,
Wollac,
bobbobbio,
capossele,
nahoc,
unizarr,
willemolding and
zeroecco
as code owners
July 8, 2026 06:59
github-actions
Bot
changed the title
Contributor
Author
|
examples passed again on this branch: https://github.com/boundless-xyz/boundless/actions/runs/28934785576 |
jonastheis
enabled auto-merge (squash)
July 8, 2026 11:27
capossele
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The last two nightly examples runs failed (2026-07-08, 2026-07-07). This fixes the code regression behind one of the two failures and makes the other fail loudly at its actual source.
Changes
Add
bytes-compat/remapping toexamples/smart-contract-requestor/remappings.txt. BM-3078: feat(contracts): run the router market on Taiko via the shared Shanghai profile #2044 addedimport {Bytes} from "bytes-compat/Bytes.sol"tocontracts/src/types/Predicate.soland the matching remapping to the rootfoundry.toml, but the example keeps its ownremappings.txt, which was not updated. Since the example importsboundless-market/types/Predicate.sol(directly and viaProofRequest.sol), its forge build broke in the first nightly run on that commit. The new remapping points at the root OpenZeppelin checkout, matching how the rest ofcontracts/srcresolves OZ imports in this build. Verified locally withforge buildandforge testin the example.Use
curl --failfor the blake3 groth16 artifact download innightly-examples.yml. The blake3-groth16 job failed both nights becauseblake3_groth16_artifacts.tar.xzis gone from the staging signal-artifacts bucket — the URL now serves a Cloudflare 404 HTML page, which curl happily saved and tar then rejected with a confusing "File format not recognized". With--fail, the download step itself fails on HTTP errors.Note: this PR does not fix the blake3-groth16 job — the artifact needs to be re-uploaded to the bucket (likely deleted by the R2 retention policy;
docker-services.ymlbakes in the same URL and is affected too). That is an ops action tracked separately.