This repository was archived by the owner on Jun 4, 2026. It is now read-only.
fix: Add currentColor for svgs in footer onhover#128
Open
SindreKjelsrud wants to merge 1 commit into
Open
Conversation
Signed-off-by: SindreKjelsrud <sindre@kjelsrud.dev>
Member
|
Would it be better if the text and the icon became highlighted instead of only the icon/text? Personally i think it would be better if we decided to either highlight both of them or none (removing the icon highlighting and keeping only text highlighting). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test by hovering on email and linkedin icons in footer when testing locally. It should change to blue-hover color like the other icons in the footer.