Chore/audit fixes 20260601 2103 - #84
Merged
Merged
Conversation
stripBackticks only removed leading/trailing backticks, so a cell like `path` (note) left a trailing backtick on the split token — scripts-catalog.json shipped 'dev/preflight-host-dev.sh`'. Strip every backtick and regenerate. Audit: F001
validate-compose pinned docker/build-push-action@v6.18.0 and setup-buildx@v3.10.0 while the release workflow used v7.2.0 / v4.1.0. Align on the newer pins so each action resolves to one SHA repo-wide. Audit: F003 (parity lint-meta rule tracked as follow-up)
Shared env-access rule was enforced at 0.1.1 in ui vs 0.1.3 in api; unify so the same env-access checks run in both apps. Audit: F004
ui pins engines.node >=24.0.0; api had only bun and docs none, despite all three using Node tooling (tsx/knip/node *.mjs). Declare consistently so older-Node environments get a warning. Audit: F006
apps/docs used caret ranges while api/ui pin exact. Pinned each dep to its currently-resolved version (astro 6.3.6, sharp 0.34.5, etc. — not the caret floor) so installs are deterministic and --frozen-lockfile stays satisfiable. Audit: F005
…nel.ts Guardrail-first: web-push.channel.ts had no test while its email/in-app/sse peers did. Extend logic-files-require-test-sibling to include .channel.ts so the gap surfaces as a lint:meta violation, then add the missing test (suppressed-on-no-subscriptions + missing-delivery-row no-op). Full api suite green (1052 pass). Audit: F008
Adds an 'Audit skills' section documenting the repo-root /audit-monorepo (read-only JSON audit) and /execute-audit (autonomous guardrail-first remediation) skills, and notes that root .claude/skills/ holds cross-app/audit skills. Audit: docs follow-up (user request)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
bun run check(orbun run check:fullfor the cross-app pass) from the repo rootcd infra/compose/compose && ./dev.sh upApp merge bars
cd apps/api && bun run validatecd apps/ui && bun run validatecd apps/docs && bun run build:cibun run check(from repo root)Conventions
any, no blindas, no!.env.example(+ SECURITY.md when relevant)Screenshots