chore(audit): execute 2026-06-10 (1223) audit — 6 findings, 3 new/extended guardrails - #157
Merged
Conversation
Extend package-override-parity to flag overrides lacking a //overrides rationale; document api's @typescript-eslint/utils pin. Audit: F002
Add github-actions-security-no-cancel lint-meta rule and set cancel-in-progress: false on all 11 *-security-{sast,secrets,deps} workflows so no pushed ref goes unscanned.
Audit: F003
…orkflows Add security-scanner-version-parity lint-meta rule so a scanner version bumped in one workflow can no longer drift from its siblings (different version = different ruleset). Audit: F006
useNotificationsList ignored pageParam and re-fetched the first page on every fetchNextPage; thread the cursor through like useActivityFeed. Add a regression test asserting page 2 sends the prior nextCursor. Audit: F001
Per-process Map enforced the resend/forgot-password cap per replica, so horizontal scale multiplied the real limit by the replica count. Use a shared Valkey counter when CACHE_PROVIDER=valkey, falling back to in-memory on any cache failure (degrade to per-process, never to no enforcement). check() is now async; await it at all 5 call sites. Audit: F004
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Executes the 2026-06-10 monorepo audit (6 findings, 0 critical / 2 high / 2 medium / 2 low). Each class-of-defect finding lands the guardrail and the fix; one-off logic bugs are fixed directly. All per-app gates green; full pre-push gate (gitleaks + semgrep + Docker smoke e2e) passed locally.
worker-configuration.d.tsin docsoverrideshad no//overridesrationale (ui/docs did)@typescript-eslint/utilspinpackage-override-parityto require a//overridesentry per override key, all appscancel-in-progress: true(PR #156 saw semgrep cancelled)*-security-{sast,secrets,deps}tofalsegithub-actions-security-no-cancel(lint-meta)security-scanner-version-parity(lint-meta, preventive)useNotificationsListignoredpageParam, re-fetched page 1 forevercursorthroughqueryFnlikeuseActivityFeed+ regression testtanstack-query-cacheplugin (flagged, not editable here)CACHE_PROVIDER=valkey, in-memory fallback on cache failure;check()now asyncDone 6/6 · failed 0 · skipped 0. 3 new/extended lint-meta guardrails close these classes for every future consumer.
Notable decisions
*-security-*(incl. dependency scans), not just sast/secrets — dependency scans are equally security gates.security.tsalready uses — no new config surface.Test plan
bun run checkfrom repo root (api / ui / docs all PASS)cd apps/api && bun run check·cd apps/ui && bun run check·cd apps/docs && bun run check:docs-dataApp merge bars
cd apps/api && bun run validatecd apps/ui && bun run validatecd apps/docs && bun run build:cibun run checkConventions
any, no blindas, no!CACHE_ENABLED/CACHE_PROVIDER)Cross-repo follow-up
@boring-stack-pkg/eslint-plugin-tanstack-query-cache: flaguseInfiniteQuerywhosequeryFnignorespageParamwhengetNextPageParamis defined — would have caught F001 statically. Lives inboringstack-xyz/eslint-plugins.