Skip to content

Commit 8165118

Browse files
agjsclaude
andauthored
chore(observability): pin Tempo image + fix size-diff workflow auth (#54)
Two small follow-ups to the recent observability work — both pure hygiene, no behavioural changes. Tempo image pinned by digest ---------------------------- PR #50 introduced `grafana/tempo:2.6.1` as a tag-only reference because OrbStack wasn't running when the commit was prepared. Every other image in the observability stack (prometheus, grafana, loki, promtail, alertmanager, postgres-exporter, node-exporter) is pinned to a specific `@sha256:` digest for supply-chain hygiene. Tempo now matches: grafana/tempo:2.6.1@sha256:ef4384fce6e8ad22b95b243d8fc165628cda655376fd50e7850536ad89d71d50 size-diff workflow github_token ------------------------------- The `bundle-diff` workflow on every PR has been printing a red ✗ with `Parameter token or opts.auth is required` since #46 introduced the dashboard work. The action (`andresz1/size-limit-action@v1.8.0`) initialises Octokit *before* reading the env var GITHUB_TOKEN, so the env-based pass we had wasn't reaching it. Fix: pass the token explicitly as a `with:` input too. The env line stays as belt-and-braces in case a future action version flips back to env. Result: no more spurious red ✗ on PRs that touch apps/ui. Verification: docker compose config dry-run exits 0 with the pinned Tempo image; workflow YAML still parses; pre-push gate green. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
1 parent b154a7b commit 8165118

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

.github/workflows/apps-ui-bundle-diff.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,13 @@ jobs:
6565
env:
6666
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6767
with:
68+
# v1.8.0 doesn't reliably fall back to env GITHUB_TOKEN — it
69+
# initialises Octokit before reading the env, so the token must
70+
# be passed explicitly as a `with:` input. Without this, every
71+
# PR run fails with "Parameter token or opts.auth is required"
72+
# even though the env was set. Keeping the env: line above as
73+
# belt-and-braces for any future action version that flips back.
74+
github_token: ${{ secrets.GITHUB_TOKEN }}
6875
package_manager: npm
6976
script: build
7077
skip_step: install

infra/compose/compose/docker-compose.observability.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ services:
125125

126126
tempo:
127127
profiles: ["observability"]
128-
image: grafana/tempo:2.6.1
128+
image: grafana/tempo:2.6.1@sha256:ef4384fce6e8ad22b95b243d8fc165628cda655376fd50e7850536ad89d71d50
129129
restart: unless-stopped
130130
command: ["-config.file=/etc/tempo/tempo.yml"]
131131
volumes:

0 commit comments

Comments
 (0)