ci: treat Branch-Protection as a one-maintainer Scorecard residual - #44
Merged
Conversation
A second human reviewer is not available in this org. Keep the live gate at one review plus the maintainer bypass, and strip BranchProtectionID from the code-scanning upload so weekly Scorecard does not reopen it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This org has one maintainer. We cannot require two human reviewers.
Live
mainprotection stays at 1 required review, CODEOWNERS@agjs, last-push approval,enforce_admins, and a maintainer bypass so that one person can still merge.Scorecard's Branch-Protection check wants two reviewers for a 10. That is not a gate we can satisfy with current headcount. This PR adds
BranchProtectionIDto the same code-scanning residual filter as Code-Review / CII / SAST / CI-Tests / Fuzzing, so the weekly Scorecard upload does not reopen it.Full results still publish to scorecard.dev.
Test plan
required_approving_review_count = 1, bypassagjs