fix: close code-scanning alerts - #39
Merged
Merged
Conversation
Move security-events write to the SARIF-upload jobs, replace existsSync plus writeFileSync with exclusive wx creates, add CODEOWNERS, and tighten desired branch-protection (reviews, code owners, required checks, enforce admins) so Scorecard Branch-Protection / Token-Permissions / Code-Review can pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the 10 open alerts on code scanning.
js/file-system-racewriteFileSafeusesflag: 'wx'instead ofexistsSyncthen writesecurity-events: writeis job-scoped on osv/semgrep/gitleaks (same pattern as CodeQL)contents: write; required for tags/PRs. Scorecard may still warn; that is the least privilege that still releasesCODEOWNERS+ desired-repo-settings: required checks, code-owner review, last-push approval, enforce admins. Apply withscripts/audit-repo-settings.shafter this mergesbun run check. Historical gaps age out once merges cannot skip CITest plan
bun run check(57 tests, includingwriteFileSafewx / skip / overwrite)scripts/audit-repo-settings.shand apply the printedgh apiPUT so Scorecard sees protection onmain