feat: confine the template to the tsforge phaser pack - #37
Merged
Conversation
Brand scene keys, dispose S/R keys on shutdown, emit the same patterns from new:scene, and add a syntactic ESLint overlay so bun run check catches ignoreDestroy, raw scene-key literals, and unmanaged timers without depending on unpublished tsforge.
Collaborator
Author
|
Companion pack: boringstack-xyz/tsforge#340 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes this template pass (and locally echo) the new tsforge
phaserrule pack.asSceneKey(Boot/World)new:sceneemitsimport * as Phaser, branded keys, andSHUTDOWNdisposedisposeno-restricted-syntaxoverlay forignoreDestroy, rawscene.start("…"),window.addEventListener, and raw timersignoreDestroy = true.tsforge/scaffold-manifest.jsonCompanion: tsforge Phaser pack PR (agjs/tsforge). This repo does not depend on unpublished
@agjs/tsforge;bun run checkcovers the syntactic subset.Test plan
bun run check(typecheck, lint, format, knip, catalog, depcruise, 55 tests)bun run test:smoke(canvas boot + loop still alive)bun run new:scene TempProbeoutput lints/formats; deleted afterphaserpack against thissrc/→ 0 errors, 0 warnings