Skip to content

repokey: use same format as with external keyfile#9693

Open
ThomasWaldmann wants to merge 2 commits into
borgbackup:masterfrom
ThomasWaldmann:sha256-repokey
Open

repokey: use same format as with external keyfile#9693
ThomasWaldmann wants to merge 2 commits into
borgbackup:masterfrom
ThomasWaldmann:sha256-repokey

Conversation

@ThomasWaldmann
Copy link
Copy Markdown
Member

  • always have a starting line with FILE_ID repoid
  • store repkeys content-addressed, name is sha256(content)
  • search by repo id on load
  • add keyfile_format / keyfile_parse / is_keyfile helpers

@codecov
Copy link
Copy Markdown

codecov Bot commented May 31, 2026

Codecov Report

❌ Patch coverage is 76.66667% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.88%. Comparing base (a6124fc) to head (9d2dd1d).
⚠️ Report is 8 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/borg/crypto/key.py 74.41% 7 Missing and 4 partials ⚠️
src/borg/repository.py 66.66% 7 Missing and 2 partials ⚠️
src/borg/crypto/keymanager.py 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9693      +/-   ##
==========================================
- Coverage   83.95%   83.88%   -0.08%     
==========================================
  Files          93       93              
  Lines       15586    15653      +67     
  Branches     2335     2351      +16     
==========================================
+ Hits        13086    13130      +44     
- Misses       1775     1789      +14     
- Partials      725      734       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- always have a starting line with FILE_ID repoid
- store repkeys content-addressed, name is sha256(content)
- search by repo id on load
- add keyfile_format / keyfile_parse / is_keyfile helpers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant