snagflash: Fastboot cmd file now supports "paths-relative-to" env variable#92
Merged
rgantois merged 1 commit intoJun 19, 2026
Merged
Conversation
bastien-sagetat
changed the title
Collaborator
|
Hi Bastien, thanks for the contrib :). I don't think this is the right way to solve this, since it breaks backwards compatibility. I'll see if I can add a parameter to enable config-file-relative paths, like what was done for snagrecover config files. |
bastien-sagetat
force-pushed
the
bsa/fastboot-relative-path
branch
2 times, most recently
from
30f1ff8 to
75576b4
Compare
bastien-sagetat
changed the title
bastien-sagetat
changed the title
rgantois
requested changes
Jun 17, 2026
rgantois
left a comment
rgantois
left a comment
Collaborator
There was a problem hiding this comment.
Other than the two changes requested below, looks great!
|
|
||
| self.checked = True | ||
|
|
||
| def _resolve_path(self, path: str) -> str: |
Collaborator
There was a problem hiding this comment.
Please remove "_" prefix to follow naming conventions in this file
| self.checked = True | ||
|
|
||
| def _resolve_path(self, path: str) -> str: | ||
| if not os.path.isabs(path): |
Collaborator
There was a problem hiding this comment.
Please change to if os.path.isabs(path): return to save an indent
bastien-sagetat
force-pushed
the
bsa/fastboot-relative-path
branch
7 times, most recently
from
76e7964 to
12e0765
Compare
bastien-sagetat
changed the title
Collaborator
|
Looks like the linter is complaining, please run |
Path resolution can be controlled through the "paths-relative-to" environement variable, which can be configured using the existing "set" command. Supported values: - CWD (default): resolve paths relative to the current working directory. - THIS_FILE: resolve paths relative to the command file's directory. Any other value raises an error. The "paths-relative-to" environment variable is documented in the help text, as well as in docs/snagflash.md Add unittests for testing this feature (tests/fastboot_uboot.py), most notably for testing the SnagflashFastbootUboot.resolve_path() method. Note: The snagrecover config file already implements this feature, with the same variable name. Signed-off-by: Christophe Guerreiro <christophe.guerreiro@non.se.com> Signed-off-by: Bastien Sagetat <sagetat.bastien@non.se.com>
bastien-sagetat
force-pushed
the
bsa/fastboot-relative-path
branch
from
12e0765 to
1d768b6
Compare
Collaborator
|
Nice, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path resolution can be controlled through the "paths-relative-to" environement variable, which can be configured using the existing "set" command.
Supported values:
Any other value raises an error.
The "paths-relative-to" environment variable is documented in the help text, as well as in docs/snagflash.md
Add unittests for testing this feature (tests/fastboot_uboot.py), most notably for testing the SnagflashFastbootUboot.resolve_path() method.
Note:
The snagrecover config file already implements this feature, with the same variable name.
Changes