Repository navigation
composefs: Fix test that only fails with fs-verity - #2552
Merged
Merged
Conversation
test_fresh_policy_replacement_preserves_objects wrote a sentinel to objects/ without creating the directory, but composefs-rs creates objects/ lazily. On filesystems without fs-verity (e.g. tmpfs/overlay in CI) the test returned early before reaching this point, so the bug went unnoticed until the Fedora Koji %check ran on a verity-capable filesystem and failed with ENOENT. Create the directory before writing the sentinel. Assisted-by: AI Signed-off-by: John Eckersberg <dev@eckersberg.com>
ckyrouac
approved these changes
Oct 6, 2026
cgwalters
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_fresh_policy_replacement_preserves_objects wrote a sentinel to
objects/ without creating the directory, but composefs-rs creates
objects/ lazily. On filesystems without fs-verity (e.g. tmpfs/overlay
in CI) the test returned early before reaching this point, so the bug
went unnoticed until the Fedora Koji %check ran on a verity-capable
filesystem and failed with ENOENT.
Create the directory before writing the sentinel.
Assisted-by: AI
Signed-off-by: John Eckersberg dev@eckersberg.com