Skip to content

Cleanup: Remove unused templates - #34

Merged
dabrorius merged 3 commits into
mainfrom
chore/remove-unused-templates
Jul 14, 2026
Merged

Cleanup: Remove unused templates#34
dabrorius merged 3 commits into
mainfrom
chore/remove-unused-templates

Conversation

@dabrorius

Copy link
Copy Markdown
Contributor

This theme is originally based on Kylie theme but it can't be edited in theme editor.
Because of that, some sections and templates that are not accessible are still in the code.

This PR tries to remove all of the dead code.

We remove:

  • Template: list-collections -> this does not seem to be accessible in any way except by guessing the URL
  • Templates: page.* -> we had about us, contact page and generic pages. These are also not accessible without guessing URL
  • Sections: A lot of sections that are not used in remaining templates. Since theme editor is not accessible it is impossible to add them to the store anyway.

Media

Some of the removed pages:
Screenshot 2026-07-13 at 15 24 48
Screenshot 2026-07-13 at 15 24 17

Copilot AI review requested due to automatic review settings July 13, 2026 13:48
@dabrorius dabrorius added review Please look at my code shop-team Shop and commerce labels Jul 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes template, section, snippet, and CSS files that are believed to be unreachable/unusable in the current theme setup (not editable via the theme editor), with the goal of reducing dead code and maintenance surface area.

Changes:

  • Deleted unused page-related templates (page.json and page.*.json) and list-collections.json.
  • Removed multiple unused sections/snippets (e.g., accordion, products, collections, form, tiles, etc.).
  • Removed the corresponding section-specific CSS assets no longer referenced by the remaining templates/sections.

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.

Show a summary per file
File Description
templates/page.json Removed unused generic page template.
templates/page.how-it-works.json Removed unused custom page template.
templates/page.contact.json Removed unused custom page template.
templates/page.about-us.json Removed unused custom page template.
templates/list-collections.json Removed unused collections-listing template.
snippets/accordion-block.liquid Removed snippet used only by the removed accordion section.
sections/tiles.liquid Removed unused tiles section.
sections/text.liquid Removed unused standalone text section.
sections/text-with-image.liquid Removed unused text-with-image section.
sections/testimonials.liquid Removed unused testimonials section.
sections/spacer.liquid Removed unused spacer section.
sections/products.liquid Removed unused products listing section.
sections/logos.liquid Removed unused logos section.
sections/list-collections.liquid Removed unused list-collections section implementation.
sections/form.liquid Removed unused form section implementation.
sections/cookie-notice-preferences.liquid Removed unused cookie notice preferences section.
sections/columns.liquid Removed unused columns section.
sections/collections.liquid Removed unused collections section.
sections/app.liquid Removed unused app wrapper section.
sections/accordion.liquid Removed unused accordion section.
assets/tiles.css Removed CSS for deleted tiles section.
assets/text-with-image.css Removed CSS for deleted text-with-image section.
assets/testimonials.css Removed CSS for deleted testimonials section.
assets/products.css Removed CSS for deleted products section.
assets/post.css Removed CSS used only by deleted sections.
assets/logos.css Removed CSS for deleted logos section.
assets/columns.css Removed CSS for deleted columns section.
assets/collections.css Removed CSS for deleted collections sections.
assets/accordion.css Removed CSS for deleted accordion section.
assets/accordion-block.css Removed CSS for deleted accordion-block snippet/section.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JKinnez JKinnez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up!
Just one thing, which is not related but I just show. Are we sure that we do not need to provide the cookie notice banner?

@dabrorius

Copy link
Copy Markdown
Contributor Author

Nice clean up! Just one thing, which is not related but I just show. Are we sure that we do not need to provide the cookie notice banner?

@JKinnez we do need it but we are ignoring that for now (product decision). Problem is that since you don't have access to theme editor you can't control this banner, so we had to default either to always showing it or never showing it and we went for never showing it. US customers generally don't want it and they are still majority of our users.

@dabrorius
dabrorius merged commit 6f4b7c5 into main Jul 14, 2026
1 check passed
@dabrorius dabrorius removed the review Please look at my code label Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shop-team Shop and commerce

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants