Raise Booqable::MissingAttribute for reads of absent attributes

[shime]

Sawyer::Resource#method_missing silently answers reads of absent attributes with nil, which has turned typos and renamed API fields (e.g. time_zone vs default_timezone, order.customer_name on a v4 order) into silent production data bugs in consuming apps.

Reading an attribute that is absent from the API payload raises Booqable::MissingAttribute instead of silently returning nil, so typos and renamed API fields fail loudly:

customer.name       # => "John Doe"
customer.full_name  # raises Booqable::MissingAttribute (key absent from payload)

An attribute that is present in the payload with a null value still returns nil — only absent keys raise:

order.customer      # => nil when the payload contains "customer": null

Booqable::MissingAttribute subclasses NoMethodError, so generic rescues keep working. To probe for an attribute that may be absent, use hash-style access or key?:

order[:customer]      # => nil when the key is absent (lenient probe)
order.key?(:customer) # => false when the key is absent

---

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

[pbalaban]

Good catch 👍

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

[devin-ai-integration]

Devin Review found 1 new potential issue.

[devin-ai-integration]

🟡 Predicate checks on built-in resource accessors incorrectly raise an error instead of returning a value

The predicate form of Sawyer's built-in accessors (e.g. .agent?, .fields?, .rels?) is not exempted from the strict-read guard (booqable_missing_attribute_read at lib/booqable/strict_attributes.rb:63) because the special-methods bypass only fires for non-predicate calls, so these valid queries raise an error instead of returning a boolean.

Impact: Calling .agent?, .fields?, or .rels? on any API resource crashes with MissingAttribute instead of returning true.

Mechanism: the SPECIAL_METHODS guard is gated on match[2].nil?

At lib/booqable/strict_attributes.rb:63:

return nil if match[2].nil? && Sawyer::Resource::SPECIAL_METHODS.include?(match[1])

When the method is agent?, match[2] is "?" (not nil), so match[2].nil? is false and the entire guard is skipped. The code then falls through to return attr_name (:agent), which triggers MissingAttribute. Sawyer's own method_missing never gets a chance to handle the predicate form of the special method.

The fix is to drop the match[2].nil? && condition so both plain and predicate forms of special methods are passed through to Sawyer:

return nil if Sawyer::Resource::SPECIAL_METHODS.include?(match[1])

Suggested change

	return nil if match[2].nil? && Sawyer::Resource::SPECIAL_METHODS.include?(match[1])
	return nil if Sawyer::Resource::SPECIAL_METHODS.include?(match[1])

---

Was this helpful? React with 👍 or 👎 to provide feedback.