Skip to content

updated logic in patch studentController #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Richard-Persson merged 1 commit into from
Sep 25, 2025
Merged

updated logic in patch studentController #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/main/java/com/booleanuk/cohorts/controllers/StudentController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,6 @@ public ResponseEntity<?> updateStudent(@PathVariable int id, @RequestBody Studen
return new ResponseEntity<>("User not found", HttpStatus.NOT_FOUND);
}

Cohort cohort = cohortRepository.findById(studentRequest.getCohortId()).orElse(null);
if (cohort == null) {
return new ResponseEntity<>("Cohort not found", HttpStatus.NOT_FOUND);
}

Profile profile = profileRepository.findById(user.getProfile().getId()).orElse(null);
if (profile == null) {
Expand Down Expand Up @@ -194,12 +190,11 @@ public ResponseEntity<?> updateStudent(@PathVariable int id, @RequestBody Studen
profile.setGithubUrl(studentRequest.getGithub_username());
}

Cohort cohort = cohortRepository.findById(studentRequest.getCohortId()).orElse(null);
if (cohort!=null) {
profile.setCohort(cohort);
}

profile.setCohort(cohort);


if (studentRequest.getEmail() != null) {
boolean emailExists = userRepository.existsByEmail(studentRequest.getEmail());
Expand Down
Loading