Skip to content

Role check implemented in cohort endpoints #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jonnashell merged 1 commit into from
Sep 23, 2025
Merged

Role check implemented in cohort endpoints #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 46 additions & 1 deletion exercise.wwwapi/Endpoints/CohortEndpoints.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@
using exercise.wwwapi.DTOs;
using exercise.wwwapi.DTOs.Cohort;
using exercise.wwwapi.DTOs.Posts;
using exercise.wwwapi.Helpers;
using exercise.wwwapi.Models;
using exercise.wwwapi.Repository;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Mvc;
using Microsoft.EntityFrameworkCore;
using System.Linq;
using System.Security.Claims;

namespace exercise.wwwapi.Endpoints
{
Expand Down Expand Up @@ -86,9 +88,19 @@ public static async Task<IResult> GetCohortByUserId(IRepository<Cohort> cohortRe
}

[Authorize]
[ProducesResponseType(StatusCodes.Status401Unauthorized)]
[ProducesResponseType(StatusCodes.Status200OK)]
public static async Task<IResult> GetAllCohorts(IRepository<Cohort> cohortService, IMapper mapper)
public static async Task<IResult> GetAllCohorts(IRepository<Cohort> cohortService, IMapper mapper, ClaimsPrincipal user)
{
if (user.Role() != (int)Roles.teacher)
{
var forbiddenResponse = new ResponseDTO<object>
{
Message = "You are not authorized to get all cohorts."
};
return TypedResults.Json(forbiddenResponse, statusCode: StatusCodes.Status403Forbidden);
}

var results = cohortService.GetWithIncludes(q => q
.Include(c => c.CohortCourses)
.ThenInclude(cc => cc.Course)
Expand All @@ -108,14 +120,24 @@ public static async Task<IResult> GetAllCohorts(IRepository<Cohort> cohortServic
}

[Authorize]
[ProducesResponseType(StatusCodes.Status401Unauthorized)]
[ProducesResponseType(StatusCodes.Status400BadRequest)]
[ProducesResponseType(StatusCodes.Status201Created)]
public static async Task<IResult> CreateCohort(
IRepository<Cohort> cohortService,
IRepository<Course> courseService,
ClaimsPrincipal user,
IMapper mapper,
CreateCohortDTO request)
{
if (user.Role() != (int)Roles.teacher)
{
var forbiddenResponse = new ResponseDTO<object>
{
Message = "You are not authorized to create a new cohort."
};
return TypedResults.Json(forbiddenResponse, statusCode: StatusCodes.Status403Forbidden);
}

var results = cohortService.GetAllFiltered(c => c.Title == request.Title);
Console.WriteLine(results);
Expand Down Expand Up @@ -164,17 +186,28 @@ public static async Task<IResult> CreateCohort(

[Authorize]
[ProducesResponseType(StatusCodes.Status200OK)]
[ProducesResponseType(StatusCodes.Status401Unauthorized)]
[ProducesResponseType(StatusCodes.Status400BadRequest)]
public static async Task<IResult> AddUserToCohort(
IRepository<Cohort> cohortService,
IRepository<User> userService,
IRepository<CohortCourse> cohortCourseService,
IRepository<CohortCourseUser> cohortCourseUserService,
IMapper mapper,
ClaimsPrincipal userCheck,
int userId,
int cohortId,
int courseId)
{
if (userCheck.Role() != (int)Roles.teacher)
{
var forbiddenResponse = new ResponseDTO<object>
{
Message = "You are not authorized to add a user to a cohort."
};
return TypedResults.Json(forbiddenResponse, statusCode: StatusCodes.Status403Forbidden);
}

// 1. Get the user
var user = userService.GetById(userId);
if (user == null)
Expand Down Expand Up @@ -253,17 +286,29 @@ public static async Task<IResult> AddUserToCohort(

[Authorize]
[ProducesResponseType(StatusCodes.Status200OK)]
[ProducesResponseType(StatusCodes.Status401Unauthorized)]
[ProducesResponseType(StatusCodes.Status400BadRequest)]
public static async Task<IResult> DeleteUserFromCohort(
IRepository<Cohort> cohortService,
IRepository<User> userService,
IRepository<CohortCourse> cohortCourseService,
IRepository<CohortCourseUser> cohortCourseUserService,
IMapper mapper,
ClaimsPrincipal userCheck,
int userId,
int cohortId,
int courseId)
{

if (userCheck.Role() != (int)Roles.teacher)
{
var forbiddenResponse = new ResponseDTO<object>
{
Message = "You are not authorized to delete a user from a cohort."
};
return TypedResults.Json(forbiddenResponse, statusCode: StatusCodes.Status403Forbidden);
}

// 1. Get the user
var user = userService.GetById(userId);
if (user == null) return TypedResults.BadRequest(new ResponseDTO<object>
Expand Down
Loading