Skip to content

fix(benchmark): resolve lint and type errors - #5

Merged
protheeuz merged 1 commit into
mainfrom
fix/benchmark-fixes
Apr 29, 2026
Merged

fix(benchmark): resolve lint and type errors#5
protheeuz merged 1 commit into
mainfrom
fix/benchmark-fixes

Conversation

@suckserberg

Copy link
Copy Markdown
Collaborator

Summary

Resolves Selene lint warnings and Luau type-inference issues in the benchmark harness. This ensures the benchmark suite runs correctly and passes all static analysis checks.

Technical Implementation

  • Server Init: Merged redundant connection logic and resolved unused import warnings.
  • Satset Mode: Fixed type casting in the payload loop to resolve "table expected, got any" errors.

Changelog Entry

  • [Benchmark]: Fixed type-inference errors and Selene linting warnings in the benchmark harness.

Type of Change

  • Feature
  • Bug Fix
  • Performance Optimization
  • Documentation Update
  • Maintenance / Chore

Verification and Standards

  • I have adhered to the Development Patterns.
  • I have verified that all CI/CD linting and formatting checks pass.
  • I have confirmed the changes within a Rojo-supported environment.

@suckserberg
suckserberg requested a review from protheeuz as a code owner April 29, 2026 22:26
@github-actions github-actions Bot added the enhancement New feature or request label Apr 29, 2026

@protheeuz protheeuz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good👍🏻

@protheeuz
protheeuz merged commit 08a8671 into main Apr 29, 2026
5 checks passed
@protheeuz
protheeuz deleted the fix/benchmark-fixes branch April 30, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants