feat(core): implement hardening and listener resilience - #4
Merged
Conversation
protheeuz
self-requested a review
April 29, 2026 22:45
protheeuz
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Core Hardening and Listener Resilience
Summary
This PR implements critical security hardening and resilience features for the Satset networking engine. It protects the library from malicious client data and ensures that internal script errors in user listeners do not halt the entire networking system.
Technical Implementation
pcallwithxpcallinPacket._dispatchSingleandChannel._applyUpdate. This provides error isolation, ensuring that one failing callback doesn't break other listeners.Satset.start()to prevent multiple initialization calls, which previously caused duplicate event listener stacking.string8,string16,array,map) insrc/Types/init.luau. It now verifies wire-provided length prefixes against the actual buffer size to prevent VM crashes or out-of-bounds reads.Changelog Entry
Type of Change
Verification and Standards