Repository navigation
Touch: a long press opens what a right-click opens - #511
Merged
Merged
Conversation
Android reports every press as the left button, a mouse's too, so a right-click never arrived. On a phone or tablet a long press on the drawn console or a generated panel opens the menu; a stop changes as the finger lifts, so a held one stays as it was. MASTERPIECE_TOUCH=1 turns it on with a mouse on a desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The right-click part of #474. On a phone or tablet a finger held still for half a second opens what a right-click opens: a stop's or piston's MIDI menu on the drawn console, a shoe's mapping, the page's own menu on the background, and an element's MIDI window on a generated panel. Android reports every press as the left button, a mouse's too, so a right-click never arrived there.
MASTERPIECE_TOUCH=1turns the same handling on with a mouse on a desktop, which is how it was checked.Checked in the program on Windows, GrandOrgue demo,
MASTERPIECE_TOUCH=1:New test
functional.ui.touch-long-press: a tap, a long press, a slide off and a small tremble, on the drawn console and on a generated panel's cell, and a mouse click unchanged.mp_tests --no-perf: 301 run, 0 failed.Still to check on an Android device: the long press with a finger and with a mouse. The combination window's pistons and the expression bar's shoes keep the right-click only for now.