Skip to content

Dialogs stay with the program when another one is in front - #509

Merged
bonninr merged 2 commits into
mainfrom
fix/dialogs-follow-front
Oct 21, 2026
Merged

bonninr merged 2 commits into
mainfrom
fix/dialogs-follow-front

Conversation

@bonninr

@bonninr bonninr commented Oct 21, 2026

Copy link
Copy Markdown
Owner

Fixes #492.

  • Settings windows and the program's other dialogs are above other programs only while Masterpiece is in front. JUCE makes a new dialog always on top whenever another of the program's windows is, and the Recorder and Combinations windows are while the program is in front, so such a dialog stayed above every other program. Each one now follows the program in and out of the front, as those windows do. Windows and macOS; Linux keeps its windows as they are.
  • macOS: an open or save panel hides while another program is in front and comes back with Masterpiece. The application installs this once at startup (MacWindows.mm); the plug-in leaves the host's panels alone.

Checked in the program on Windows, GrandOrgue demo, Recorder open, then Organ settings, then another program (Notepad) brought to the front; the topmost flag of each window:

Moment Organ settings, before Organ settings, after Recorder
Masterpiece in front topmost topmost topmost
Notepad in front topmost: stays above Notepad not topmost not topmost
Masterpiece in front again topmost topmost

The file dialog part is macOS only: built by the macOS jobs here, and on the Mac test list.

mp_tests --no-perf: 300 run, 0 failed.

An open or save panel hides when the program leaves the front and comes
back with it, as the Recorder and Combinations windows do. The
application installs this once at startup; a plug-in leaves the host's
panels alone.
@bonninr
bonninr merged commit cc1c9cb into main Oct 21, 2026
10 checks passed
@bonninr
bonninr deleted the fix/dialogs-follow-front branch October 21, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting windows are on top of all other apps

2 participants