Skip to content

Organ settings: the MIDI tab's keyboard rows fit - #508

Merged
bonninr merged 1 commit into
mainfrom
fix/organ-settings-size
Oct 21, 2026
Merged

bonninr merged 1 commit into
mainfrom
fix/organ-settings-size

Conversation

@bonninr

@bonninr bonninr commented Oct 21, 2026

Copy link
Copy Markdown
Owner

Fixes the layout part of #493.

  • Organ settings opens 780 wide, enough for each keyboard's row on the MIDI tab at full width: name, channel, device and "Range, transpose...". The height stays 560, which a 720-pixel screen holds whole; the tabs scroll.
  • In a narrower window the device box gives way first, down to 140, and the range button keeps its 160. Players who opened Organ settings before keep their saved size, the old 660 wide, so this is what they see.

Checked in the program on Windows, GrandOrgue demo, Organ settings > MIDI:

Window Before After
Saved size 662 x 588 (the old default, as kept in dialogs.txt) the three "Range, transpose..." buttons about 75 px wide, their text shrunk to a few pixels the buttons read "Range, transpose..." in full; the device boxes are narrower
First opening, no saved size as above 798 x 627 on screen, every row at full width, the note beside "Clear default" whole

The size the player leaves the window at is kept since 0.7.3: opened, resized, closed and reopened at the new size on Windows, and again after a restart. The report is from macOS, where this is still to be checked.

mp_tests --no-perf: 300 run, 0 failed.

@bonninr
bonninr merged commit e1267d1 into main Oct 21, 2026
10 checks passed
@bonninr
bonninr deleted the fix/organ-settings-size branch October 21, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants