Repository navigation
Update check and Download: the newest release on GitHub - #506
Merged
Merged
Conversation
The once-a-day check reads GitHub's record of the newest release from api.github.com and takes the version from its tag. A plain number is still read as it is, for MASTERPIECE_UPDATE_URL. The site's version.txt stays for the versions already out.
The notice's Download button opens the newest release's page on GitHub, with its downloads. The setting's tooltip says the number comes from GitHub, in all eight languages.
bonninr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The once-a-day update check reads GitHub's record of the newest release,
https://api.github.com/repos/bonninr/masterpiece/releases/latest, and takes the version from its tag (v0.9.0gives0.9.0). Drafts and pre-releases are left out of "latest" by GitHub.User-Agent: MasterpieceandAccept: application/vnd.github+json, on Windows and macOS through JUCE and on Linux through curl.MASTERPIECE_UPDATE_URLkeeps working with a test server or a copy.https://github.com/bonninr/masterpiece/releases/latest, the newest release's page with its downloads.version.txton the site stays: 0.8.1 and earlier read it.functional.settings.update-checkchecks the tag, a plain number, and that a portal's page, a rate-limit refusal and a tag that is not a version give nothing.Checked in the program on Windows:
update check: this is the newest, 0.8.1v0.9.0update check: 0.9.0 is out, this is 0.8.1