Repository navigation
Score: en dashes round the page number on Windows - #503
Merged
Merged
Conversation
Verovio's sources hold UTF-8 text, such as the en dashes round a page number and the accidentals of a chord symbol, and MSVC read them in the system code page: page 2 onwards was numbered with three stray characters either side. Verovio now compiles with /utf-8 on MSVC. functional.score.engraver checks that the second page's number sits between two en dashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, the page number from page 2 onwards reads
– 2 –in the score panel. Verovio's sources hold the en dashes round the number as UTF-8 literals (runningelement.cpp), and MSVC read them in the system code page. The accidentals and symbols of MusicXML chord symbols (iomusxml.cpp: ♯ ♭ ♮ 𝄪 𝄫 △ °) went through the same path.Verovio now compiles with
/utf-8on MSVC. Clang and GCC read source as UTF-8 already.functional.score.engraverchecks that the second page's number sits between two U+2013 en dashes.Checked in the program on Windows: the trio fixture, page 2, before and after.