Skip to content

Generated panel: each divisional piston in its own division's column - #502

Merged
bonninr merged 1 commit into
mainfrom
fix/divisionals-in-division
Oct 21, 2026
Merged

bonninr merged 1 commit into
mainfrom
fix/divisionals-in-division

Conversation

@bonninr

@bonninr bonninr commented Oct 21, 2026

Copy link
Copy Markdown
Owner

The generated panel draws each divisional piston in its own division's column. The generals stay in Pistons.

Fixes #489.

Changes

  • The GrandOrgue import writes the manual's division on each of its divisionals (DivisionID on the Combination row).
  • The definition loader reads it into Combination::divisionId.
  • panelSections() puts a combination that has a division in that division's section; one without stays in Pistons.

Test

functional.ui.panel-divisionals: two manuals, each with divisionals named "1" and "2" (the Walcker Wildervank naming), and one general. Each manual's divisionals land in its own column; the general stays in Pistons. Full functional pass on Windows: 301 run, 0 failed.

Checked in the program

The GrandOrgue demo with two divisionals named "1" and "2" drawn on each of its three divisions, a generated panel, Fit on, graphics only, Windows:

build where the divisionals are
main all six in Pistons, three "1"/"2" pairs between the generals
this branch "1" and "2" at the foot of Pedal, First Manual and Second Manual; Pistons holds the generals only

@bonninr
bonninr merged commit fdf1bd0 into main Oct 21, 2026
10 checks passed
@bonninr
bonninr deleted the fix/divisionals-in-division branch October 21, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Divisionals on Panel

2 participants