Repository navigation
Score: the cursor stays in sight through a new layout - #500
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a new layout (two pages, a zoom, a new window size), the score panel shows the page holding the cursor.
The page shown used to be the one holding the next note to sound. With the cursor inside a page's last held notes, that note is on the next page, and the cursor was left out of sight. In BWV 565, a stop in the held pedal chord under the Lento followed by Two pages showed the Allegro page first.
Now the page comes from the notes the cursor marks: the one that began last decides. On a rest, the page of the next note, as before.
Tests
functional.score.cursor-page, with a fixture of sixteen held whole notes over six small pages. It sets 63 starts, re-lays the score out in one and two pages after each, and checks that a cursor note is on a page shown.