Skip to content

Score: the cursor stays in sight through a new layout - #500

Merged
bonninr merged 2 commits into
mainfrom
fix/score-keeps-cursor-page
Oct 21, 2026
Merged

bonninr merged 2 commits into
mainfrom
fix/score-keeps-cursor-page

Conversation

@bonninr

@bonninr bonninr commented Oct 21, 2026

Copy link
Copy Markdown
Owner

After a new layout (two pages, a zoom, a new window size), the score panel shows the page holding the cursor.

The page shown used to be the one holding the next note to sound. With the cursor inside a page's last held notes, that note is on the next page, and the cursor was left out of sight. In BWV 565, a stop in the held pedal chord under the Lento followed by Two pages showed the Allegro page first.

Now the page comes from the notes the cursor marks: the one that began last decides. On a rest, the page of the next note, as before.

Tests

  • New test functional.score.cursor-page, with a fixture of sixteen held whole notes over six small pages. It sets 63 starts, re-lays the score out in one and two pages after each, and checks that a cursor note is on a page shown.
    • Without the fix: 27 of the 126 layouts lose the cursor.
    • With the fix: 0.
  • Full suite on Windows: 300 run, 0 failed.
  • In the program with BWV 565: Play, Stop and Two pages at three places (bar 8, bar 9, and the held chord under the Lento). The cursor's page is the left page each time.

@bonninr
bonninr merged commit 784e1b3 into main Oct 21, 2026
10 checks passed
@bonninr
bonninr deleted the fix/score-keeps-cursor-page branch October 21, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants