Repository navigation
Attack emphasis: each pipe begins louder or softer and comes to its own level - #442
Merged
Merged
Conversation
bonninr
marked this pull request as ready for review
October 20, 2026 01:21
bonninr
force-pushed
the
feature/attack-emphasis
branch
3 times, most recently
from
October 21, 2026 10:47
a40e447 to
9ee2baa
Compare
bonninr
force-pushed
the
feature/attack-emphasis
branch
from
October 21, 2026 14:35
9ee2baa to
c3b6a3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for CI, stacked on #430 (live levels). Organ settings, Voicing EQ: Attack in dB and its length in ms, saved with the organ and in the control API as attackDb and attackMs. During a note's attack the emphasis is folded into the tremulant's per-frame level ramp, so voices with none take today's path; a test checks the output is bit-identical with it off. Translations and manual included.