fix(matrix): correct vars block to be a dict instead of list of dicts#28
Open
0cwa wants to merge 1 commit into
Open
fix(matrix): correct vars block to be a dict instead of list of dicts#280cwa wants to merge 1 commit into
0cwa wants to merge 1 commit into
Conversation
Ansible 2.10+ rejects 'vars: [- key: value, ...]' under a play with: ERROR: Vars in a Play must be specified as a dictionary. The dashes were a copy/paste hangover from the 'roles:' list above. Re-indent the body so each var is a top-level key in the dict. No semantic change. Verified with: yamllint -c .yamllint.yaml playbooks/matrix.yml ansible-playbook --syntax-check -i hosts/prod playbooks/matrix.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a pre- existing bug surfaced by
ansible-playbook --syntax-check:The
vars:block was written as a list of single-key dicts (a copy/paste hangover from theroles:list above it). Re-indented so each var is a top-level key in the dict, and added aname:to the play.** No semantic change** — vault values preserved verbatim.
Verified with
Stacking
First in the chain. Land this before
chore/ci-lint,feat/docker-role, and thefeat/funkwhale-*PRs — they all need a syntax-cleanplaybooks/matrix.ymlso the new lint workflow stays green.moz-extension://5084ac1a-3029-49cd-a02f-37beec949c9f/index.html