Skip to content

feat(input): correct caret position when adding emojis - #63

Open
lukediamond wants to merge 13 commits into
emoji-miscfrom
emoji-misc-caret
Open

feat(input): correct caret position when adding emojis#63
lukediamond wants to merge 13 commits into
emoji-miscfrom
emoji-misc-caret

Conversation

@lukediamond

Copy link
Copy Markdown
Member

@lukediamond
lukediamond requested a review from misterupkeep June 6, 2021 02:37
@lgtm-com

lgtm-com Bot commented Jun 7, 2021

Copy link
Copy Markdown

This pull request fixes 1 alert when merging 56556c6 into 602f2e2 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com

lgtm-com Bot commented Jun 7, 2021

Copy link
Copy Markdown

This pull request fixes 1 alert when merging 627f8a8 into 602f2e2 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com

lgtm-com Bot commented Jun 7, 2021

Copy link
Copy Markdown

This pull request fixes 1 alert when merging 562197f into 602f2e2 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

Comment thread components/TextInput.vue Outdated
Comment thread components/TextInput.vue Outdated
@misterupkeep

Copy link
Copy Markdown
Member

I didn't review just now, no matter what it might say, this is referring to the original commit. Doesn't work on Chrome, and Firefox is pretty broken too. Here's the bisect for the crash on Chrome

56556c67ade7d9fb8f5bf6cf44942aa765039803 is the first bad commit
commit 56556c67ade7d9fb8f5bf6cf44942aa765039803
Author: 00drip
Date:   Sun Jun 6 21:47:25 2021 -0400

    feat(input): improve caret handling

 components/Chat/ChatMessageForm.vue |  11 +++-
 components/TextInput.vue            | 111 ++++++++++++++++++++++++------------
 2 files changed, 83 insertions(+), 39 deletions(-)

@lgtm-com

lgtm-com Bot commented Jun 7, 2021

Copy link
Copy Markdown

This pull request fixes 1 alert when merging fabb550 into 602f2e2 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com

lgtm-com Bot commented Jun 7, 2021

Copy link
Copy Markdown

This pull request fixes 1 alert when merging 7172191 into 602f2e2 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lukediamond

Copy link
Copy Markdown
Member Author

All the problems I'm aware of have been resolved, take a look and we could probably have this merged by today.

@lgtm-com

lgtm-com Bot commented Jun 8, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert and fixes 1 when merging d4e2a7b into 602f2e2 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com

lgtm-com Bot commented Jun 8, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert and fixes 1 when merging d6a43da into 602f2e2 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com

lgtm-com Bot commented Jun 9, 2021

Copy link
Copy Markdown

This pull request introduces 1 alert and fixes 1 when merging 449da04 into 602f2e2 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com

lgtm-com Bot commented Jun 13, 2021

Copy link
Copy Markdown

This pull request fixes 1 alert when merging 9e1bd28 into 602f2e2 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com

lgtm-com Bot commented Jun 13, 2021

Copy link
Copy Markdown

This pull request fixes 1 alert when merging b47e45a into 602f2e2 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com

lgtm-com Bot commented Jun 13, 2021

Copy link
Copy Markdown

This pull request fixes 1 alert when merging 6e4bfe6 into 602f2e2 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants