docs: record the two declined modernizer analyzers - #9
Merged
Merged
Conversation
No guidance file existed in this repository, so the decision to decline embedlit and omitzero lived only in a commit message and a PR body. An unqualified `go fix ./...` would silently re-propose both. embedlit is not hypothetical here: across the plugin fleet it proposed rewrites in five of fourteen repositories, and in bomly-plugin-template it was the only thing the modernizer found -- an unqualified run there would have propagated flattened Coordinates into every plugin created from it. AGENTS.md and CLAUDE.md are identical copies, matching bomly-sdk's convention. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repository had no guidance file, so the decision to decline two modernizer analyzers lived only in a commit message and a PR body. An unqualified
go fix ./...silently re-proposes both, and nothing mechanical objects.embedlitis not hypothetical here. Across the fourteen-repo plugin fleet it proposed rewrites in five repositories — and inbomly-plugin-templateit was the only thing the modernizer found, which means an unqualified run there would have propagated flattenedCoordinatesinto every plugin created from the template.omitzeromoves no bytes, so no test or linter objects — but the tag is thebomly.plugin.v1wire schema, and a reflection-based consumer then reads the field as required.bomly-sdktook that rewrite once and spent four review rounds undoing it.Mirrors
bomly-sdk's convention:AGENTS.mdandCLAUDE.mdare identical copies.🤖 Generated with Claude Code