-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(assurance): three-stage release assurance framework with a published per-release report #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bomly-guy
wants to merge
14
commits into
main
Choose a base branch
from
feat/release-assurance-framework
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f4cc3d8
feat(assurance): framework core, catalog, and consolidation
bomly-guy c876acb
feat(assurance): stage 1 — release prerequisites
bomly-guy 7a3b821
feat(assurance): stage 2 — pre-release gate
bomly-guy 7030f22
feat(assurance): stage 3 — post-release assessment
bomly-guy d9fc9af
fix(assurance): correct the workflow wiring an adversarial review found
bomly-guy 75f9581
refactor(assurance): link counts to their jobs, and drop what repeats…
bomly-guy a38946e
feat(assurance): make subject areas the report's structure
bomly-guy c3f7c5f
docs(assurance): one vocabulary, and a rule for changing a schema
bomly-guy a1701cf
feat(assurance): symmetric claims, and coverage as one stamp per ecos…
bomly-guy aff590d
docs(assurance): finish the agent-facing documentation
bomly-guy 9965c6f
fix(assurance): act on the review findings
bomly-guy 56dd97b
fix(assurance): keep the goldens workflow from running the ref it ref…
bomly-guy 58593a1
fix(assurance): make the public-download claim true, not smaller
bomly-guy b9c4fad
Merge origin/main into feat/release-assurance-framework
bomly-guy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,170 @@ | ||
| # Stage 1 of Bomly's release assurance framework: everything that must hold | ||
| # before a version is tagged. It runs on the source tree, so a failure here is | ||
| # fixed by an ordinary pull request rather than by a broken release. | ||
| # | ||
| # Auto Version calls this workflow and only tags when it passes. Release | ||
| # preflight then looks for a successful run against the commit being released, | ||
| # so a hand-made tag cannot skip it. | ||
| # | ||
| # The checks it collects are declared in docs/assurance/catalog.json. | ||
| name: Release prerequisites | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| ref: | ||
| description: Commit, branch, or tag to check (defaults to this ref). | ||
| type: string | ||
| required: false | ||
| default: "" | ||
| workflow_call: | ||
| inputs: | ||
| ref: | ||
| description: Commit, branch, or tag to check. | ||
| type: string | ||
| required: false | ||
| default: "" | ||
| assurance_tag: | ||
| description: Release tag recorded in the check results. | ||
| type: string | ||
| required: false | ||
| default: "" | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: assurance-prerequisites-${{ inputs.ref || github.ref }} | ||
| cancel-in-progress: false | ||
|
|
||
| jobs: | ||
| smoke: | ||
| name: End-to-end scans | ||
| uses: ./.github/workflows/smoke.yml | ||
| with: | ||
| ref: ${{ inputs.ref || github.ref }} | ||
| assurance: true | ||
| assurance_tag: ${{ inputs.assurance_tag }} | ||
|
|
||
| portable: | ||
| name: Platform stability | ||
| uses: ./.github/workflows/portable-assurance.yml | ||
| with: | ||
| ref: ${{ inputs.ref || github.ref }} | ||
| assurance: true | ||
| assurance_tag: ${{ inputs.assurance_tag }} | ||
|
|
||
| # Fuzzing is advisory: a finding is recorded in the report and does not stop a | ||
| # release. `continue-on-error` is not allowed on a job that calls a reusable | ||
| # workflow, so fuzz.yml itself skips its failing step when it is called in | ||
| # assurance mode; the verdict job below is what decides the stage. | ||
| fuzz: | ||
| name: Parser fuzzing | ||
| uses: ./.github/workflows/fuzz.yml | ||
| with: | ||
| ref: ${{ inputs.ref || github.ref }} | ||
| fuzztime: 45s | ||
| assurance: true | ||
| assurance_tag: ${{ inputs.assurance_tag }} | ||
|
|
||
| catalog: | ||
| name: Assurance catalog | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
| steps: | ||
| - name: Check out repository | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| ref: ${{ inputs.ref || github.ref }} | ||
| persist-credentials: false | ||
|
|
||
| - name: Set up Go | ||
| uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 | ||
| with: | ||
| go-version-file: go.mod | ||
| cache: true | ||
| cache-dependency-path: go.sum | ||
|
|
||
| - name: Validate the assurance catalog | ||
| id: catalog | ||
| continue-on-error: true | ||
| run: make assurance-catalog | ||
|
|
||
| - name: Record the catalog result | ||
| if: always() | ||
| env: | ||
| BOMLY_ASSURANCE_TAG: ${{ inputs.assurance_tag }} | ||
| CATALOG_OUTCOME: ${{ steps.catalog.outcome }} | ||
| run: | | ||
| set -euo pipefail | ||
| exit_code=0 | ||
| summary="The assurance catalog is valid and every fixture and expected-result file it names still matches its recorded checksum." | ||
| if [ "${CATALOG_OUTCOME}" != "success" ]; then | ||
| exit_code=1 | ||
| summary="The assurance catalog is invalid or one of the files it names has changed. Open the validation step for the exact entry." | ||
| fi | ||
| checks="$(grep -c '"stage":' docs/assurance/catalog.json || true)" | ||
| # --stage and --level are explicit: when the catalog is the thing | ||
| # that is broken, the emitter cannot look them up in it. | ||
| go run ./internal/assurance/cmd emit \ | ||
| --id catalog-valid --stage prerequisites --level gate \ | ||
| --exit-code "${exit_code}" --summary "${summary}" \ | ||
| --metric checks="${checks}" --out assurance-results --step-summary | ||
|
|
||
| - name: Upload check result | ||
| if: always() | ||
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 | ||
| with: | ||
| name: assurance-catalog | ||
| path: assurance-results | ||
| if-no-files-found: error | ||
| retention-days: 7 | ||
|
|
||
| - name: Fail the job when the catalog is invalid | ||
| if: steps.catalog.outcome == 'failure' | ||
| run: exit 1 | ||
|
|
||
| verdict: | ||
| name: Prerequisites verdict | ||
| if: always() | ||
| needs: [smoke, portable, fuzz, catalog] | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
| steps: | ||
| - name: Check out repository | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| with: | ||
| ref: ${{ inputs.ref || github.ref }} | ||
| persist-credentials: false | ||
|
|
||
| - name: Set up Go | ||
| uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0 | ||
| with: | ||
| go-version-file: go.mod | ||
| cache: true | ||
| cache-dependency-path: go.sum | ||
|
|
||
| - name: Collect check results | ||
| uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 | ||
| with: | ||
| pattern: assurance-* | ||
| merge-multiple: true | ||
| path: assurance-results | ||
|
|
||
| - name: Judge the prerequisites stage | ||
| env: | ||
| BOMLY_ASSURANCE_TAG: ${{ inputs.assurance_tag }} | ||
| run: | | ||
| go run ./internal/assurance/cmd verdict \ | ||
| --results assurance-results --stage prerequisites \ | ||
| --tag "${BOMLY_ASSURANCE_TAG}" \ | ||
| --json assurance-results/stage-prerequisites.json --step-summary | ||
|
|
||
| - name: Upload the stage report | ||
| if: always() | ||
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 | ||
| with: | ||
| name: assurance-stage-prerequisites | ||
| path: assurance-results | ||
| if-no-files-found: error | ||
| retention-days: 30 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.